Commit Graph

43 Commits

Author SHA1 Message Date
Zorica Stojchevska 30e5087084 Update copyright
MAILAND-2696
2022-05-23 21:01:57 +00:00
Davide Giuseppe Farella 792c85f2f6 Deleted config/detekt/config.yml 2022-01-20 15:34:11 +00:00
Davide Farella bc6abbbbbf Fix Unlimited Slider hint for Local Storage 2022-01-19 13:51:20 +00:00
Davide Farella 96c9d8a14b Refactor SwipeChooserViewModelTest.kt
* remove no longer needed mocks
* rename functions to match recent agreements
* simplify test cases

MAILAND-2573
2022-01-14 13:01:47 +00:00
Davide Farella 63fe71daee Remove public fields from SwipeChooserViewModel.kt
Extras are retrieved directly from the Activity's Intent and values are
set by a function now

MAILAND-2573
2022-01-14 13:01:47 +00:00
Davide Farella 327ed2e6e6 Handle exceptions in UpdateSwipeActions.kt
Map the result into UpdateSwipeActions.Result

MAILAND-2573
2022-01-14 13:01:47 +00:00
Marino Meneghel 34f3b441fb Update core detekt plugin
The plugin now contains a fix for the codequality issue on gitlab,
so the workaround to inject "severity" into the report can be dropped.
2021-12-16 18:08:43 +01:00
Tomasz Giszczak 006629dde0 Fixed some detekt issues and updated the counter.
MAILAND-1525
2021-10-20 14:24:02 +02:00
Tomasz Giszczak 50ca951dd6 Updated Search Activity with new LabelEntity after rebase.
MAILAND-1525
2021-10-20 14:24:02 +02:00
Tomasz Giszczak 3e98b76cb1 Resolved some messages gap fix rebase problems.
MAILAND-1525
2021-10-20 14:21:46 +02:00
Tomasz Giszczak 23e672d10e Updated label entity and label id refernces fater rebase.
MAILAND-1525
2021-10-20 14:21:45 +02:00
Tomasz Giszczak 74d50d1cdb Moved labels related stuff to the new package.
MAILAND-1525
2021-10-20 14:20:02 +02:00
Tomasz Giszczak 912bf719ed Fixed some detekt formatting issues. 2021-07-26 18:24:23 +02:00
Tomasz Giszczak aef9c92074 Update detekt command run on CI and the current error count. 2021-07-15 20:22:53 +02:00
Tomasz Giszczak 3b8f25ced9 Updated detekt issues count.
MAILAND-1968
2021-07-14 18:09:58 +02:00
Tomasz Giszczak 4ffab952d7 Refactored MessageDetailsViewModel, updated fetching messages and conversations tests.
MAILAND-1968
2021-07-14 16:21:59 +02:00
Tomasz Giszczak ef1c544787 Fixed big part of detekt formatting errors. Counter lowered to 2052. Removed unused files.
MAILAND-1792
2021-07-07 14:15:11 +00:00
Tomasz Giszczak 276752fe03 Updated detect count to 3300.
MAILAND-1558
2021-07-05 06:53:42 +00:00
Tomasz Giszczak 314389cf3c Updated detekt counter to 3600.
MAILAND-1792
2021-07-01 08:26:30 +00:00
Davide Farella ce996acdeb Fetch assert4k from Maven Central 2021-05-04 17:26:28 +02:00
Davide Farella 642520ec84 Remove check for old sdk versions in the code 2021-04-20 15:20:08 +00:00
Davide Farella 59e7a67c78 Pass user id correctly trough login
MAILAND-1629
2021-03-25 12:31:55 +01:00
Davide Farella cd4692b40d Fix tests after rebase
MAILAND-1189
2021-03-19 16:17:35 +01:00
stefanija ed9caa549f Remove redundant google-services file for beta
The google-services file for beta is redundant since its data is contained in the main google-services file.

MAILAND-1194
2020-12-03 16:12:21 +00:00
Tomasz Giszczak 75c6220733 Reformatting of NavigationActivity and related.
MAILAND-1111
2020-12-01 10:19:20 +01:00
Marino Meneghel 3b8e10c491 Decrease detekt's maxIssues and exclude buildSrc folder
MAILAND-750
2020-10-29 11:20:01 +00:00
Tomasz Giszczak e0a1ecd7a0 LogoutWorker added.
MAILAND-1000
2020-10-22 09:17:23 +00:00
stefanija ae1f74ac45 Allow build without google-services.json files
Add dummy google-services.json files when building the GitHub public project.

MAILAND-1027
2020-10-21 17:07:28 +02:00
Tomasz Giszczak 44d02a80be Updated deteKt config threshold.
MAILAND-953
2020-10-15 13:25:58 +02:00
Zorica Stojchevska 4b3928f310 Changed build version
#comment Just increased the build version code for a new beta
Affected: nothing
2020-10-14 17:41:12 +02:00
Davide Farella 9d224ea58c Nullable Address.domainId
domainId for Address.kt and Address.java must be nullable, differently from what explained in the doc
Affected: AddressesBridgeMapper.kt
2020-10-02 10:33:46 +02:00
Davide Farella 301473695e Sync Detekt rule-set form GitHub
It should be fixing our code climate
Affected: Detekt config
2020-08-27 11:06:43 +02:00
Davide Farella b29fa69756 Fix Detekt rule-set
Detekt rule-set has been recently messed up by some accidental change
Affected: Detekt setup
2020-08-26 16:22:25 +02:00
Zorica Stojchevska 3cb1395088 Enable plural forms -> "Please remove %2$d items."
#comment Decided to delete the observer that was using the mentioned string, cause we weren't using this observer.  Affected: Nothing.

MAILAND-726
2020-08-25 13:30:10 +02:00
Davide Farella 428dcd9a18 Updated Detekt rules and removed misc.xml
Synced Detekt rules-set from Core project
Removed misc.xml because it contains values that can vary on different JDK setups
Affected: none
2020-08-19 18:32:24 +00:00
Davide Farella b64657f5f9 Added missing pref keys for User fields
#comment Added missing Constants.kt for SharedPreferences's for User fields:
- prefix `PREF_USER`
* credit
* currency
* id
* name
* org private key
* services
Affected: none

MAILAND-791
2020-07-09 14:09:58 +00:00
Davide Farella 8f10947c12 Usage of unified Detekt config from Core
Affected: build config
2020-07-02 10:47:52 +00:00
Davide Farella de9ab3b028 Added Validators and User's fields
Updated Detekt rule-set in order to match Core's config ( allowing uppercase functions )
Affected: none

MAILAND-719
2020-07-02 10:47:52 +00:00
Davide Farella ebd95ad69d Imported Detekt setup from Core library
#comment Removed built-in Detekt setup and switched with the one from Core Util Gradle package
Affected: detekt reports and code climate on CI
2020-06-29 12:06:21 +00:00
Zorica Stojchevska 699d1b346f Clean up string resources (part 2)
#comment Remove string resources that are not used.
Affected: String resources

MAILAND-557
2020-06-04 11:10:42 +00:00
Davide Farella a2409d5553 Test assertions and Rules/interfaces
#comment ArchTest.kt, CoroutinesTest.kt and Assertions.kt ported from Composer branch.
Added ViewStateStoreTest.kt
Slightly changed Detekt config for:
* exclude `TooGenericExceptionThrown` from test classes
* Allow function naming stating with uppercase, which a common Kotlin pattern for create virtual constructors
* Allow wildcard import `kotlin.test.*`
Affected: nothing
2020-05-21 09:26:24 +00:00
Davide Farella 02cc831eb2 Updated detekt code analysis version
#comment Updated to to 0.3.2 which includes fixes for issues' fingerprint
Affected: Code climate reports for MRs
2020-05-07 08:46:55 +02:00
Davide Farella 6fa62b2e70 Contributions documentation
#comment Added contributions' guideline in Readme and exported config/CodeStyle.xml for setup IDE's Code Style rules
Affected: README.md

MAILAND-599
2020-05-06 18:59:04 +00:00