72d67e9b6c
Create use case to orchestrate logic to show "rate app" dialog
...
- Do not save feature flag value in memory: it's already saved in the DB
MAILAND-3071
2023-04-12 11:59:10 +00:00
6417f17cc1
Extract show rate app logic to the viewModel
...
The StartRateAppFlow is in a dedicated use case to allow abstracting the
usage of context
MAILAND-3071
2023-04-12 11:59:10 +00:00
054ce56605
Show review app dialog to the user when needed
...
The current conditions for the dialog to show is for the feature flag to
be true, the user to have seen mailbox screen twice in the same
session and to not being resuming the app from the background (which is
achieved by incrementing the "mailbox screen views" count only when
going back from a Detail screen).
MAILAND-3071
2023-04-12 11:59:10 +00:00
39e59e2c7b
Add google play review dependency
...
This will be used to handle in-app review requests
MAILAND-3071
2023-04-12 11:59:10 +00:00
f3c08abb28
Increase mailbox views count when closing a detail screen
...
This count will be used to define when a user can be presented with the
"rate app" dialog. We increase the count when going back from the detail
rather than at some point in the mailbox screen's lifecycle to avoid the
case where the dialog is shown when resuming mailbox from the
background.
MAILAND-3071
2023-04-12 11:59:10 +00:00
b4b8c2e4ad
Refresh and store in memory feature flag to show rate-app dialog
...
MAILAND-3071
2023-04-12 11:59:10 +00:00
6d26f9cfb9
Merge branch 'chore/agp_7_4_2' into 'develop'
...
chore: Bump Android Gradle Plugin to 7.4.2.
See merge request android/mail/proton-mail-android!1254
2023-04-12 09:33:43 +00:00
e997d4fe2d
chore: Bump Android Gradle Plugin to 7.4.2.
2023-04-11 10:58:15 +02:00
5c1c0a47f6
Merge branch 'chore/translations-2023-04-10_061844' into 'develop'
...
i18n: Upgrade translations from crowdin (375d7045
2023-04-10 07:56:31 +00:00
17da8fdd15
i18n: Upgrade translations from crowdin ( 375d7045).
2023-04-10 06:18:44 +00:00
375d704514
Merge branch 'refactor/auth_activities_manifest' into 'develop'
...
refactor(auth): Updated Auth Activities AndroidManifest (scrollable & portrait).
See merge request android/mail/proton-mail-android!1250
2023-04-06 16:05:04 +00:00
dc52849bf8
fix: Updated ExistingUserOnboardingViewModel to use new welcome_header_mail drawable.
2023-04-06 14:58:07 +02:00
9566279547
refactor(auth): Updated Auth Activities AndroidManifest (scrollable & portrait).
2023-04-04 17:09:18 +02:00
438b4794b3
Merge branch 'feat/external_account_conversion_cap_c' into 'develop'
...
feat: Added External Account Sign In Conversion support.
See merge request android/mail/proton-mail-android!1248
2023-04-04 13:13:17 +00:00
529b49f32c
chore(user-settings): Migration OrganizationDatabase.MIGRATION_2.
2023-04-04 10:35:44 +00:00
d8e99206c2
feat: Added External Account Sign In Conversion support.
2023-04-04 10:35:44 +00:00
316d4930d3
Merge branch 'chore/update-docker-image' into 'develop'
...
Update CI runner docker image to v1.1.0
See merge request android/mail/proton-mail-android!1249
2023-04-04 08:56:39 +00:00
e57930ff1b
Update CI runner docker image to v1.1.0
...
This is needed to ensure CI runner has the updated ssh host key
for github. Also brings some other image improvements (changed base image)
NO-JIRA
2023-03-31 14:05:30 +02:00
a1bc112c1f
Merge branch 'chore/gradle_android_7_4_1' into 'develop'
...
chore: Upgraded Android Gradle Plugin to 7.4.1.
See merge request android/mail/proton-mail-android!1239
2023-03-02 13:42:16 +00:00
8fefc366e8
chore: Upgraded Android Gradle Plugin to 7.4.1.
2023-03-02 13:29:08 +01:00
237b971722
Changed build version for a new release
2023-02-28 15:52:42 +01:00
3d2e0b3814
Merge branch 'fix/gradle_build_file_dir' into 'develop'
...
build: Resolve files using the `rootDir`, for better compatibility with Core's meta-repo.
See merge request android/mail/proton-mail-android!1247
2023-02-28 14:51:04 +00:00
fafddfb05e
build: Resolve files from the `rootDir`, for better compatibility with Core's meta-repo.
2023-02-28 13:36:26 +00:00
42942998a9
Merge branch 'chore/translations-2023-02-27_064235' into 'develop'
...
i18n: Upgrade translations from crowdin (79539164
2023-02-28 13:35:38 +00:00
6d77844084
i18n: Upgrade translations from crowdin ( 79539164).
2023-02-28 12:37:41 +00:00
dedb8ba0dc
Merge branch 'feat/observability_support' into 'develop'
...
feat: Added Observability support (Core 9.12.0).
See merge request android/mail/proton-mail-android!1245
2023-02-27 14:30:09 +00:00
2f7c757096
feat: Added Observability support (Core 9.12.0).
2023-02-24 15:23:04 +01:00
7953916404
Merge branch 'fix/foreign_key_reference_alter_rename_table' into 'develop'
...
fix: Revert PRAGMA foreign_keys. Keep PRAGMA legacy_alter_table always ON (default in Android).
See merge request android/mail/proton-mail-android!1243
2023-02-20 15:53:33 +00:00
c8b967852b
fix: Revert PRAGMA foreign_keys. Keep PRAGMA legacy_alter_table always ON (default in Android).
2023-02-20 14:52:47 +00:00
a75b0a253d
Merge branch 'chore/translations-2023-02-20_065017' into 'develop'
...
i18n: Upgrade translations from crowdin (8dbae8e5
2023-02-20 14:50:14 +00:00
db8ae1e523
i18n: Upgrade translations from crowdin ( 8dbae8e5).
2023-02-20 06:50:18 +00:00
8dbae8e578
Merge branch 'chore/translations-2023-02-13_064817' into 'develop'
...
i18n: Upgrade translations from crowdin (4a80dd84
2023-02-17 09:51:30 +00:00
5243ffda0c
i18n: Upgrade translations from crowdin ( 4a80dd84).
2023-02-16 16:44:27 +00:00
29bd5b730f
Merge branch 'fix/foreign_key_reference_alter_rename_table' into 'develop'
...
fix: Fixed foreign key reference to be renamed while recreating/altering target table.
See merge request android/mail/proton-mail-android!1242
2023-02-16 16:16:15 +00:00
643050bc01
fix: Fixed foreign key reference to be renamed while recreating/altering target table.
2023-02-16 16:24:16 +01:00
3b65ea55ed
Merge branch 'chore/bump-version-number' into 'develop'
...
Bump version code for new alpha build
See merge request android/mail/proton-mail-android!1241
2023-02-14 12:22:54 +00:00
da6e68c4a0
Bump version code for new alpha build
...
MAILAND-3059
2023-02-14 09:54:30 +01:00
22ed83aab0
Merge branch 'fix/3059-attachments-removed-after-being-added' into 'develop'
...
Fix issues where attachments are removed from composer
See merge request android/mail/proton-mail-android!1240
2023-02-14 08:51:37 +00:00
4faf3d7615
Fix issues where attachments are removed from composer
...
This issue's first visible cause is a race condition: if we open a new
composer, type in a recipient, subject and body and then press the "add
attachment" button _with the right timing_ the issue will happen.
The "right timing" seem to be couple of seconds: the assumption is that
the save draft flow have to be started but not finished.
This is due to the result of the "save draft" flow (which is triggered
automatically after we stop typing) is stored in a liveData which does
not get consumed by the composer activity till the "add attachments activity"
drawn on top returns. Once this live data is consumed, it overrides one
field that the "result" of add attachments activity did just set -
effectively removing the attachment.
This is the key part of this issue, as previously the livedata seemed to
be consumed anyways and thus the race condition was not encountered
(or very unlikely to happen).
While git bisect points the issue started with commit "Targeting sdk 33
to allow for granular media permissions" [6c951a] (which is the reason
for the fix being a rollback of target sdk) this doesn't seem to be the
whole story. Few other changes dependencies update happened at the
same time (kotlin update, activity and coroutines libs updated transitely
through core).
Such bits seem to be concurring to creating the issue, making it uneasy
to define one single root cause with confidence.
MAILAND-3059
2023-02-13 17:00:16 +01:00
4a80dd8407
Merge branch 'fix/4905-prevent-draft-body-loss' into 'develop'
...
Prevent draft body from being lost when not loaded locally
See merge request android/mail/proton-mail-android!1236
2023-02-07 09:00:47 +00:00
a70ef67c07
Make offline dialog when opening a draft not cancellable
...
This prevents users from dismissing the dialog (with the back button or
tapping outside of it) and triggering a draft update with no content
when exiting the composer (causing the loss of the draft).
CLIENT-4905
2023-02-06 12:22:30 +01:00
99c122ed7d
Prevent draft body from being lost when not loaded locally
...
On low connectivity, opening a draft for the first time (meaning
its body was never fetched) and the exiting the composer before such
loading finished, would cause the draft to be updated with the local
content of the body - empty - causing its loss.
This commit introduces a flag that's set when the VM schedules the
"fetchDraftDetailJob" and reset when such job returns any result
(success or failure). When the user exits the composer, this flag is
checked and if found set the draft will not be saved.
CLIENT-4905
2023-02-06 11:46:13 +01:00
2bf7c39a90
Merge branch 'chore/translations-2023-02-06_064708' into 'develop'
...
i18n: Upgrade translations from crowdin (b8ca2f2c
2023-02-06 08:18:02 +00:00
cf3db7e8aa
i18n: Upgrade translations from crowdin ( b8ca2f2c).
2023-02-06 06:47:09 +00:00
b8ca2f2cf1
Merge branch 'fix/signup_dummy_domains_call' into 'develop'
...
fix(auth): Get Domains when Sign Up flows start.
See merge request android/mail/proton-mail-android!1234
2023-02-03 12:58:49 +00:00
e979648ba3
fix(auth): Get Domains when Sign Up flows start.
...
chore: Upgraded Core to 9.9.1.
2023-02-02 08:32:55 +00:00
211803fe5f
Merge branch 'chore/translations-2023-01-30_065324' into 'develop'
...
i18n: Upgrade translations from crowdin (24a01410
2023-02-02 08:32:38 +00:00
6ee8d388ef
i18n: Upgrade translations from crowdin ( 24a01410).
2023-01-30 06:53:24 +00:00
24a01410dd
Add dark mode support to webview above sdk 33
2023-01-29 22:21:25 +01:00
e0cd8ff800
Changed build version for a new release
2023-01-27 10:15:38 +01:00
Marino Meneghel
Neil Marietta
Zorica Stojchevska
proton-ci
Zorica Stojchevska
Mateusz Armatys