codevalet
/
canary
mirror of https://github.com/codevalet/canary
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #13 from rtyler/less-sentry 

Prevent predictable response errors from Sentry from re-raising as errors
This commit is contained in:
R. Tyler Croy 2017-12-19 08:54:04 -08:00 committed by GitHub
parent 30188bfa62 2c2303a700
commit 8e1707e01c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/canary/dao/sentry.rb
View File

@ -12,6 +12,13 @@ module CodeValet::Canary::DAO
class Sentry
attr_reader :error
# List of somewhat predictable errors from Sentry which shouldn't be
# re-raised as errors into Sentry by the Canary application
SENTRY_ERRORS = [
SentryApi::Error::Parsing,
SentryApi::Error::ResponseError,
]
CACHE_SECONDS = 60
def errored?
@ -31,7 +38,7 @@ module CodeValet::Canary::DAO
:expires_in => 10 * CACHE_SECONDS) do
SentryApi.projects
end
rescue *CodeValet::Canary::DAO::NET_ERRORS, SentryApi::Error::Parsing => e
rescue *CodeValet::Canary::DAO::NET_ERRORS, *SENTRY_ERRORS => e
@error = e
return []
rescue StandardError => e
@ -50,9 +57,7 @@ module CodeValet::Canary::DAO
:expires_in => CACHE_SECONDS) do
SentryApi.project_issues(project_key)
end
rescue *CodeValet::Canary::DAO::NET_ERRORS,
SentryApi::Error::Parsing,
SentryApi::Error::NotFound => e
rescue *CodeValet::Canary::DAO::NET_ERRORS, *SENTRY_ERRORS => e
@error = e
return []
rescue StandardError => e
@ -72,7 +77,7 @@ module CodeValet::Canary::DAO
:expires_in => 5 * CACHE_SECONDS) do
SentryApi.issue(id)
end
rescue *CodeValet::Canary::DAO::NET_ERRORS, SentryApi::Error::Parsing => e
rescue *CodeValet::Canary::DAO::NET_ERRORS, *SENTRY_ERRORS => e
@error = e
return nil
rescue StandardError => e
@ -86,7 +91,7 @@ module CodeValet::Canary::DAO
:expires_in => CACHE_SECONDS) do
SentryApi.issue_events(id)
end
rescue *CodeValet::Canary::DAO::NET_ERRORS, SentryApi::Error::Parsing => e
rescue *CodeValet::Canary::DAO::NET_ERRORS, *SENTRY_ERRORS => e
@error = e
return nil
rescue StandardError => e