Clean up some minor codenarc complaints

This commit is contained in:
R. Tyler Croy 2015-08-08 18:35:17 -07:00
parent 14cc95fa9e
commit f7c756839c
No known key found for this signature in database
GPG Key ID: 1426C7DC3F51E16F
5 changed files with 12 additions and 8 deletions

View File

@ -164,7 +164,7 @@ ruleset {
InconsistentPropertyLocking
InconsistentPropertySynchronization
InsecureRandom
Instanceof
//Instanceof
IntegerGetInteger
InterfaceName
InterfaceNameSameAsSuperInterface
@ -184,7 +184,7 @@ ruleset {
JUnitUnnecessarySetUp
JUnitUnnecessaryTearDown
JUnitUnnecessaryThrowsException
JavaIoPackageAccess
//JavaIoPackageAccess
JdbcConnectionReference
JdbcResultSetReference
JdbcStatementReference
@ -320,7 +320,7 @@ ruleset {
UnnecessaryPackageReference
UnnecessaryParenthesesForMethodCallWithClosure
UnnecessaryPublicModifier
UnnecessaryReturnKeyword
//UnnecessaryReturnKeyword
UnnecessarySafeNavigationOperator
UnnecessarySelfAssignment
UnnecessarySemicolon

View File

@ -1,12 +1,13 @@
package com.github.jrubygradle.groovygem
import com.fasterxml.jackson.annotation.JsonProperty
import groovy.transform.CompileStatic
import groovy.transform.TypeChecked
import sun.org.mozilla.javascript.commonjs.module.Require
/**
*/
@TypeChecked
@CompileStatic
class Dependency {
@JsonProperty
String name

View File

@ -58,7 +58,7 @@ class Gem {
/**
* Take the given argument and produce a {@code Gem} instance
*
* @param metadata a {@code java.lang.String} or a {@code java.io.File}
* @param metadata a {@code java.lang.String}, a {@code java.io.File} or a {@code java.util.zip.GZIPInputStream}
* @return
*/
static Gem fromFile(Object metadata) {
@ -73,13 +73,13 @@ class Gem {
metadataFile = metadata as File
}
else if (metadata instanceof InputStream) {
return mapper.readValue(metadata, Gem.class)
return mapper.readValue(metadata, Gem)
}
if (!(metadataFile?.exists())) {
return null
}
return mapper.readValue(metadataFile, Gem.class)
return mapper.readValue(metadataFile, Gem)
}
}

View File

@ -1,10 +1,11 @@
package com.github.jrubygradle.groovygem
import com.fasterxml.jackson.annotation.JsonProperty
import groovy.transform.CompileStatic
import groovy.transform.TypeChecked
/**
*/
@TypeChecked
@CompileStatic
class Requirement {
}

View File

@ -1,9 +1,11 @@
package com.github.jrubygradle.groovygem
import com.fasterxml.jackson.annotation.JsonProperty
import groovy.transform.CompileStatic
/**
*/
@CompileStatic
class Version {
@JsonProperty
String version