nextcloud
/
bookmarks
mirror of https://github.com/nextcloud/bookmarks
0
0
Fork 0
Code Issues Releases Wiki Activity

Performance: Speed up deletions 

...by removing one unnecessary find query
This commit is contained in:
Marcel Klehr 2020-09-10 10:36:44 +02:00
parent 353a050f35
commit b6b2e49cc1
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Db/TreeMapper.php
View File

@ -267,6 +267,7 @@ class TreeMapper extends QBMapper {
$childFolders = $this->findChildren(self::TYPE_FOLDER, $id);
foreach ($childFolders as $childFolder) {
$this->deleteEntry(self::TYPE_FOLDER, $childFolder->getId());
$this->folderMapper->delete($childFolder);
}
$childBookmarks = $this->findChildren(self::TYPE_BOOKMARK, $id);
@ -280,9 +281,6 @@ class TreeMapper extends QBMapper {
}
$this->remove($type, $id);
$folder = $this->folderMapper->find($id);
$this->folderMapper->delete($folder);
}
if ($type === self::TYPE_SHARE) {

1
lib/Service/BookmarkService.php
View File

@ -390,6 +390,7 @@ class BookmarkService {
}
$folders = $this->treeMapper->findChildren(TreeMapper::TYPE_FOLDER, $rootFolder->getId());
foreach ($folders as $folder) {
$this->folderMapper->delete($folder);
$this->treeMapper->deleteEntry(TreeMapper::TYPE_FOLDER, $folder->getId());
}
}

2
lib/Service/FolderService.php
View File

@ -182,6 +182,7 @@ class FolderService {
}
$publicFolder = $this->publicFolderMapper->findByFolder($folderId);
$this->publicFolderMapper->delete($publicFolder);
$this->folderMapper->delete($folder);
return;
}
@ -199,6 +200,7 @@ class FolderService {
// folder is subfolder of share
$this->treeMapper->deleteEntry(TreeMapper::TYPE_FOLDER, $folder->getId());
$this->folderMapper->delete($folder);
}
/**