nextcloud
/
contacts
mirror of https://github.com/nextcloud/contacts
0
0
Fork 0
Code Issues Releases Wiki Activity

Use absolute path for icon url 

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
This commit is contained in:
Christoph Wurst 2017-04-11 09:22:46 +02:00
parent 07f1bb1013
commit a309d7c280
No known key found for this signature in database
GPG Key ID: CC42AC2A7F0E56D8
2 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/ContactsMenu/Providers/DetailsProvider.php
View File

@ -64,8 +64,9 @@ class DetailsProvider implements IProvider {
// TODO: unique contact URL to the contacts app
// TODO: l10n
$iconUrl = $this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('core', 'actions/info.svg'));
$contactsUrl = $this->urlGenerator->getAbsoluteURL('/index.php/apps/contacts');
$action = $this->actionFactory->newLinkAction('icon-info', 'Details', $contactsUrl);
$action = $this->actionFactory->newLinkAction($iconUrl, 'Details', $contactsUrl);
$action->setPriority(0);
$entry->addAction($action);
}

25
tests/unit/ContactsMenu/Provider/DetailsProviderTest.php
View File

@ -58,16 +58,23 @@ class DetailsProviderTest extends PHPUnit_Framework_TestCase {
$entry->expects($this->exactly(2))
->method('getProperty')
->will($this->returnValueMap([
['UID', 'e3a71614-c602-4eb5-9994-47eec551542b'],
['isLocalSystemBook', null]
]));
['UID', 'e3a71614-c602-4eb5-9994-47eec551542b'],
['isLocalSystemBook', null]
]));
$this->urlGenerator->expects($this->once())
->method('imagePath')
->with('core', 'actions/info.svg')
->willReturn('core/img/actions/info.svg');
$iconUrl = 'https://example.com/core/img/actions/info.svg';
$this->urlGenerator->expects($this->exactly(2))
->method('getAbsoluteURL')
->with('/index.php/apps/contacts')
->willReturn('cloud.example.com/index.php/apps/contacts');
->will($this->returnValueMap([
['/index.php/apps/contacts', 'cloud.example.com/index.php/apps/contacts'],
['core/img/actions/info.svg', $iconUrl],
]));
$this->actionFactory->expects($this->once())
->method('newLinkAction')
->with($this->equalTo('icon-info'), $this->equalTo('Details'), $this->equalTo('cloud.example.com/index.php/apps/contacts'))
->with($this->equalTo($iconUrl), $this->equalTo('Details'), $this->equalTo('cloud.example.com/index.php/apps/contacts'))
->willReturn($action);
$action->expects($this->once())
->method('setPriority')
@ -96,9 +103,9 @@ class DetailsProviderTest extends PHPUnit_Framework_TestCase {
$entry->expects($this->exactly(2))
->method('getProperty')
->will($this->returnValueMap([
['UID', 1234],
['isLocalSystemBook', true]
]));
['UID', 1234],
['isLocalSystemBook', true]
]));
$entry->expects($this->never())
->method('addAction');