From 69692922cf1da8998aa76758c32400b73e3a73ad Mon Sep 17 00:00:00 2001
From: NeroBurner <pyro4hell@gmail.com>
Date: Sun, 23 Oct 2022 21:45:16 +0200
Subject: [PATCH] Update CMake usage in README build instructions

CMake 3.14.0 released in March 2019 [1] added the command line config options
`-S <source-dir>` and `-B <build-dir>` and the build argument `--build <build-dir>` [2].
These options are universally valid independent of the build system used (`make`,
`nmake`, `ninja`, `MSBuild`,...), making the provided CMake commands more generic.

As reference Ubuntu 20.04 ships the CMake 3.16.3 [3] version.

- [1] https://gitlab.kitware.com/cmake/cmake/-/tags/v3.14.0
- [2] https://cmake.org/cmake/help/v3.14/release/3.14.html#command-line
- [3] https://packages.ubuntu.com/focal/cmake

Signed-off-by: NeroBurner <pyro4hell@gmail.com>
---
 README.md | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 06b300e4c..38cb45c15 100644
--- a/README.md
+++ b/README.md
@@ -15,12 +15,10 @@ with your computer.
 
 #### :memo: Step by step instructions
 
-##### Clone the repo and create build directory
+##### Clone the repo
 ```
 $ git clone https://github.com/nextcloud/desktop.git
 $ cd desktop
-$ mkdir build
-$ cd build
 ```
 ##### Compile and install
 
@@ -33,14 +31,14 @@ $ cd build
 ##### Linux & Mac OS
 
 ```
-$ cmake .. -DCMAKE_INSTALL_PREFIX=~/nextcloud-desktop-client -DCMAKE_BUILD_TYPE=Debug
-$ make install
+$ cmake -S . -B build -DCMAKE_INSTALL_PREFIX=~/nextcloud-desktop-client -DCMAKE_BUILD_TYPE=Debug
+$ cmake --build build --target install
 ```
 
 ##### Windows
 
 ```
-$ cmake -G "Visual Studio 15 2017 Win64" .. -DCMAKE_INSTALL_PREFIX=$USERPROFILE\nextcloud-desktop-client -DCMAKE_BUILD_TYPE=Debug
+$ cmake -S . -B build -G "Visual Studio 15 2017 Win64" -DCMAKE_INSTALL_PREFIX=$USERPROFILE\nextcloud-desktop-client -DCMAKE_BUILD_TYPE=Debug
 $ cmake --build . --config Debug --target install
 ```