nextcloud
/
desktop
mirror of https://github.com/nextcloud/desktop
0
0
Fork 0
Code Issues Releases Wiki Activity
19,630 Commits 420 Branches 237 Tags 361 MiB
Commit Graph

56 Commits

Author SHA1 Message Date
Dimitri Papadopoulos 9d830e94f9 Fix typos found by codespell 
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
Matthieu Gallien 7118fc4650 use a better name for encryption status attributes 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-12 15:46:51 +02:00
Matthieu Gallien 8659df2266
prevent downgrading e2ee metadata format after initial migration 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
alex-z 1b0a93eabc
Migrate E2EE from v1 to v1.1 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-03-31 17:18:28 +02:00
alex-z b6ba1fe0d6 Implement Secure filedrop link share. Move data from 'filedrop' to 'files' when syncing E2EE folders. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-03-02 19:29:11 +01:00
alex-z bd9eb0c89f Always unlock E2EE folders, even when network failure or crash. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-30 16:01:19 +01:00
alex-z 75fd1d21be Always generate random initialization vector when uploading encrypted file. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-18 11:54:13 +01:00
alex-z cdbdf8620d remove unrelated changes 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-18 11:41:55 +01:00
alex-z 4644581af9 remove unrelated changes 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-18 11:41:55 +01:00
alex-z 286a43e9fb Fix memory leak. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-18 11:41:55 +01:00
alex-z 260ba0be46 Fix security vulnerability when receiving empty metadataKeys from the server. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-18 11:41:55 +01:00
allexzander eb80f54dcf E2EE Fix incorrect name of a nested encrypted item in the Settings dialog when the root folder is non-encrypted and it is renamed. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-01-25 10:35:54 +02:00
allexzander 483a874cb6 Fix folder upload issue due to wrong Lock/Unlock order 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-01-25 10:35:30 +02:00
Kevin Ottens 36b8e7c2a4
Remove the encryption flag check from encrypted propagation code 
If we use those encrypted propagation code paths, we already know from
the discovery phase (and thus the journal db) that the folders are
encrypted so no need to check again.

This will remove another expensive round trip with the server.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:23 +01:00
Kevin Ottens 567f678fd5
Make sure the encrypted flag gets all the way to the journal db 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:21 +01:00
Hannah von Reth 93152761a1
Use verbose function names instead of direct member access 2020-12-15 10:59:20 +01:00
Kevin Ottens eb76682b1e Use httpd/unix-directory mimetype for E2EE folders 
We don't do much with that mimetype on our end, but other clients
somehow don't expect inode/directory to let's lie. ;-)

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-31 10:08:48 +00:00
Kevin Ottens 26686ecd45 Recover from missing metadata on uploads 
Other clients seem to allow creating empty encrypted folders with no
metadata associated to them, so let's get ready to handle it. In case of
a 404 to get the metadata, we create an empty metadata payload and pass
it further down.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-07-09 16:22:54 +02:00
Kevin Ottens 8a181adb3a Always use an absolute remote path for GetFolderEncryptStatusJob 
It turns out this job expected an absolute remote path even in the case
of a subfolder sync point.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-07-01 16:58:29 +00:00
Kevin Ottens d7a9a4cd09 Fix parenting issues of PropagateUploadEncrypted 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-06-30 11:29:08 +02:00
Kevin Ottens 710c470c13 Assume that folder paths can be mangled 
PropagateUploadEncrypted made the assumption of the folder names never
being mangled. This is not true since the previous commits so make sure
we properly deal with that using the journal db.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-06-30 11:29:08 +02:00
Kevin Ottens 319e441653 Make PropagateUploadEncrypted reusable in a directory context 
It was assuming we'd encrypt only files but directory names also need to
be encrypted. We just skip the writing to temp file part in that case.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-06-30 11:29:08 +02:00
Kevin Ottens 5afcf71e68 Fix typo 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-06-30 11:29:08 +02:00
Sandro Knauß 6cdae6c19e Fix typos. 
Debian has a list of known typos in their checking tools.

Signed-off-by: Sandro Knauß <hefee@debian.org>
 2020-05-04 18:11:36 +00:00
Roeland Jago Douma ce545b1e47
propage*encrypted Q_UNUSED 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-07-02 12:45:44 +02:00
Roeland Jago Douma f7bf8c7577
Thread local storage don't work properly on OSX 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-06-14 21:26:07 +02:00
Daniel Nicoletti 3e05bd1da0 Do not detach encrypted files vector 2018-04-09 13:23:52 +02:00
Daniel Nicoletti a9208f6581 Remove unused encrypted property 2018-04-09 13:23:52 +02:00
Daniel Nicoletti 60fc5d6dd4 Fix upload of existing encrypted files by matching only filename 2018-04-09 13:23:52 +02:00
Tomaz Canabrava 6c88367ac6 Do not crash if there was an error encrypting the file. 2018-03-26 21:44:46 +02:00
Tomaz Canabrava 5fe9717598 Potentially fix crash acessing a deleted pointer. 2018-03-26 21:37:13 +02:00
Tomaz Canabrava 96115be0c6 Unlock folder in case of error 2018-03-25 21:54:08 +02:00
Daniel Nicoletti 99117078f3 Remove table for e2e and add an e2eMangledName column (#169) 
If the code was not complex enough syncing two tables
already started to give UNIQUE constrains errors on
simple sync operations, this also adds initial support
remote delete of an encrypted file
 2018-02-12 12:50:51 +01:00
Roeland Jago Douma 1eb7ba72f0
Use standardized filename 
See https://github.com/nextcloud/end_to_end_encryption_rfc/issues/13

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-09 11:40:06 +01:00
Roeland Jago Douma 296f46356e
If the metadata is empty we should store (and not update). 
Android only creates the metadata file when the first encrypted file is
added. We assumed it would be there.

This hacky code makes us store the metadata if there wasn't any yet.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-29 22:04:50 +01:00
Tomaz Canabrava dcc9ac7d2e [Buildfix] Fix build from last merge 2018-01-29 14:17:52 +01:00
Tomaz Canabrava e9a7a56359 [CSE] Store the encrypted file name on the SyncFilePtr 2018-01-28 18:37:01 +01:00
Roeland Jago Douma 4892b0ec43
Properly fill EncryptedFile 
* Add a mimetype (mobile clients need this)
* Add the tag unencoded as we encode it when we send the metadata
already

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-23 21:31:00 +01:00
Roeland Jago Douma bb85e2ab2c
Reuse existing EncryptedFile 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-23 11:36:15 +01:00
Roeland Jago Douma 33beb7aade
Don't generate values after we use them 
* Pregerenate IV
* Pregenerate key
* Pregenerate filename

TODO:
  - Reuse existing file entries and update (we might need logic in the
  metadatahandling to do this properly).
 2018-01-22 15:24:54 +01:00
Tomaz Canabrava cf2fa2ea35 [CSE] Get the tag of the encrypted file to feed the metadata 
Also, change the logging cattegory
 2018-01-21 21:59:19 +01:00
Tomaz Canabrava 5d6817e165 [CSE] Save the tag while encrypting. 2018-01-21 21:49:24 +01:00
Daniel Nicoletti a7ee1a95a6 Download and decrypt file if parent folder is marked as encrypted 2018-01-08 21:08:31 +01:00
Daniel Nicoletti e2c895e61f Fix encrypted file location on the server 2017-12-29 17:28:35 +01:00
Daniel Nicoletti ca92c46970 Add category logging to PropagateUploadEncrypted 2017-12-29 17:28:35 +01:00
Tomaz Canabrava da9f1c412d [CSE] Remove debug 2017-12-24 16:36:57 +01:00
Tomaz Canabrava 06c34ed617 [CSE] Assorted fixes 
- Unlock the folder even on error
- Use the correct name of the file for upload
 2017-12-24 16:30:39 +01:00
Tomaz Canabrava 60ef722b60 [CSE] Update the metadata when a file is being uploaded. 2017-12-22 23:05:39 +01:00
Tomaz Canabrava b72113a53d [CSE] Prepare the beginning of the upload. 
I still need to send the metadata.
 2017-12-21 00:35:23 +01:00
Tomaz Canabrava df5fd3fbe6 [CSE] More debug output, fix input file path 2017-12-21 00:00:27 +01:00