mirror of https://github.com/nextcloud/server
address review
Signed-off-by: Simon L <szaimen@e.mail.de>
This commit is contained in:
parent
531f5d1e4f
commit
b681cf735a
|
@ -3075,14 +3075,7 @@
|
|||
<file src="lib/private/Preview/Generator.php">
|
||||
<InvalidArgument>
|
||||
<code>$maxPreviewImage</code>
|
||||
<code>$semId</code>
|
||||
</InvalidArgument>
|
||||
<InvalidReturnStatement>
|
||||
<code>$sem</code>
|
||||
</InvalidReturnStatement>
|
||||
<InvalidReturnType>
|
||||
<code>false|resource</code>
|
||||
</InvalidReturnType>
|
||||
<LessSpecificReturnType>
|
||||
<code>null|string</code>
|
||||
</LessSpecificReturnType>
|
||||
|
|
|
@ -221,7 +221,7 @@ class Generator {
|
|||
*
|
||||
* @param int $semId
|
||||
* @param int $concurrency
|
||||
* @return false|resource the semaphore on success or false on failure
|
||||
* @return false|\SysvSemaphore the semaphore on success or false on failure
|
||||
*/
|
||||
public static function guardWithSemaphore(int $semId, int $concurrency) {
|
||||
if (!extension_loaded('sysvsem')) {
|
||||
|
@ -240,11 +240,11 @@ class Generator {
|
|||
/**
|
||||
* Releases the semaphore acquired from {@see Generator::guardWithSemaphore()}.
|
||||
*
|
||||
* @param resource|bool $semId the semaphore identifier returned by guardWithSemaphore
|
||||
* @param false|\SysvSemaphore $semId the semaphore identifier returned by guardWithSemaphore
|
||||
* @return bool
|
||||
*/
|
||||
public static function unguardWithSemaphore($semId): bool {
|
||||
if ($semId === false || get_class($semId) !== 'SysvSemaphore' || !extension_loaded('sysvsem')) {
|
||||
public static function unguardWithSemaphore(false|\SysvSemaphore $semId): bool {
|
||||
if ($semId === false || !($semId instanceof \SysvSemaphore)) {
|
||||
return false;
|
||||
}
|
||||
return sem_release($semId);
|
||||
|
|
Loading…
Reference in New Issue