Commit Graph

7062 Commits

Author SHA1 Message Date
Christoph Wurst 78842348b2
feat(dependencyinjection): Allow optional (nullable) services
Allows working with classes that might or might not be available.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-03 11:53:43 +01:00
Ferdinand Thiessen 84421f4c7c
Merge pull request #41137 from nextcloud/chore/migrate-access-level-cypress
chore(cypress): Migrate access-level tests from Behat to Cypress
2023-11-02 17:44:52 +01:00
Christoph Wurst ac168cf9ff feat(contactsmenu): Show user status
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-31 11:52:46 -07:00
Ferdinand Thiessen 8e2824ea24
chore(tests): Migrate duplicated menu settings tests (access levels) to Cypress
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-30 01:05:25 +01:00
Ferdinand Thiessen bfc8b0bc15
chore(cypress): Migrate access-level tests from Behat to Cypress as this are UI tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-29 23:36:58 +01:00
Christopher Ng ce5e290d58 fix(tests): Test profile entry
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-26 10:30:22 -07:00
Ferdinand Thiessen 5b0c27b6da
fix(settings): Stablize user list cypress tests
* Use common `data-testid` to identify elements rather than to depend on internal classes or properties
* Force clean the state for the user tests
* Move leftover acceptance tests for users from drone to cypress

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-25 11:36:24 +02:00
Ferdinand Thiessen 4c4e4ec991 chore(tests): Migrate login acceptance tests from behat to Cypress
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-23 16:10:06 +02:00
Ferdinand Thiessen e9d4036389
feat(theming): Allow to configure default apps and app order in frontend settings
* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-20 00:24:17 +02:00
Ferdinand Thiessen 363d9ebb13
feat(NavigationManager): Always sort the default app first
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-19 22:04:20 +02:00
Ferdinand Thiessen 154a9989a7
Merge pull request #39852 from nextcloud/pragmaHeader
Stop sending deprecated Pragma header
2023-10-18 03:30:21 +02:00
Christopher Ng 0b8958fae7 fix(acceptance): Locate settings menu
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-16 09:54:41 -07:00
Christoph Wurst b914916bdb
Merge pull request #40749 from nextcloud/refactor/contacts-menu-to-vue
refactor: Contacts menu to Vue
2023-10-16 18:12:39 +02:00
Christoph Wurst 6a375ca161 refactor: Contacts menu to Vue
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-10-16 14:12:20 +00:00
Joas Schilling 500fa5431d
Fix unit tests on PHP 8.3
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-16 10:17:22 +02:00
Christoph Wurst ff672b11e2
feat: Add factory method for in-memory caches
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-11 13:37:22 +02:00
Côme Chilliet ee39a47e84
Fix Dynamic property timeFactory in ClientFlowLoginControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-09 10:30:54 +02:00
Christopher Ng 744a7e291a fix(acceptance): Locate contacts menu button
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-06 14:40:33 -07:00
Joas Schilling ccb01b19a0
fix(sqlite): Remove some old SQLite cheats
- Doctrine correctly forces integer for autoincrement by now
- Doctrine correctly maintains integer types by now

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:27 +02:00
Joas Schilling 160298c556
fix(mysql): Remove custom MySQL workaround from 2015
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +02:00
Joas Schilling b202b139dd
fix(postgres): Remove old Postgres 9.4 workaround
Postgres 10 is the minimum in the meantime
and doctrine/dbal fixed this in 2.6.0 already
ref https://github.com/doctrine/dbal/pull/2614

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +02:00
Joas Schilling ad839dbb0a
fix(sqlite): Remove no longer required autoincrement fix
- I installed current master and exported the schema as SQL
- Then I went to this branch, removed the content of the run() method (so made it no-op)
- I installed again and exported the schema as SQL
- The files are exactly the same, so whatever we tried to fix was fixed since 2015 in doctrine dbal

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +02:00
Julien Veyssier 807f173dec
make oauth2 authorization code expire after 10 minutes
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-10-05 14:24:02 +02:00
Christoph Wurst 0e64ec6550
chore: Install phpunit via vendor bin
This means we can all run the same version. And when switching to
stableX it can pull the corresponding version too. Also local dev envs
and CI run the same phpunit.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-02 11:33:14 +02:00
Christoph Wurst 04ecc2a6a9
feat(backgroundjob): Schedule job after <timestamp>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-09-29 10:29:40 +02:00
julia.kirschenheuter 5693092053 Split list to navigation for the left sidebar
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-09-28 18:18:40 +02:00
Côme Chilliet c9ed1e981b
Merge pull request #40617 from nextcloud/enh/allow-user-to-set-apporder
Read apporder from configuration value
2023-09-28 10:55:52 +02:00
Faraz Samapoor c322224650 Refactors tests/app.php to improve readaibility.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-27 09:10:47 +03:30
Côme Chilliet b11eb9e6d6
Fix and extend NavigationManagerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 16:21:22 +02:00
Côme Chilliet 2d28e8110f
Fix and extend tests for AppManager::getDefaultAppForUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 14:59:05 +02:00
Joas Schilling 0956b493b6
fix(phonenumber): Use the newly introduced API to limit 3rdparty lib usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-25 15:54:21 +02:00
Daniel Kesselberg 97a024f035 chore(3rdparty): remove opis/closure
- We are using laravel/serializable-closure for a while now.
- The package was there for compatibility reasons but does not play nice with PHP 8.1.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-22 17:16:20 +02:00
Joas Schilling 5e7b41086d
feat(CI): Allow apps to test with PHPUnit10
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-21 21:32:15 +02:00
Robin Appelman b11ca34bbd
Merge pull request #40499 from nextcloud/known-mtime-wrapper
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is
2023-09-21 18:33:15 +02:00
Daniel Kesselberg 18af7cc86b test: add test for cache mount provider
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-20 15:42:23 +02:00
Robin Appelman ccf8843d9f apply known mtime wrapper for external storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-19 13:58:35 +02:00
Robin Appelman 5bf34979fe add wrapper to ensure we don't get an mtime that is lower than we know it is
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-19 13:58:15 +02:00
John Molakvoæ (skjnldsv) ef1abd958c
fix(systemtags): fix capabilities and sidebar + tag visibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-18 16:44:28 +02:00
Côme Chilliet 0c421975bd Remove last calls to deprecated at matcher in tests/Core
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-18 10:21:21 +02:00
Côme Chilliet b36fb96984
Merge pull request #40419 from nextcloud/fix/remove-at-matcher-in-installer-test
Remove deprecated at matcher in tests/lib/InstallerTest.php
2023-09-18 09:45:58 +02:00
Lucas Azevedo 03ece129bf
refactor(f2v): Migrate unread comments action to the new FileAction API
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-09-16 14:08:47 +02:00
Côme Chilliet e24007b530
Remove deprecated at matcher in tests/lib/InstallerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-14 12:52:05 +02:00
Julius Härtl 7f958e81d3
fix: Pass parent to NonExistingFile instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-13 10:28:28 +02:00
Daniel Kesselberg f8f985602b
test: add tests for dns pin middleware
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-12 14:04:23 +02:00
Côme Chilliet 4f1e5bc8fd
Merge pull request #32912 from nextcloud/group-backend-batch-method
Add batch methods in user backends
2023-09-11 11:11:00 +02:00
Julius Härtl 938a558078
Merge pull request #39226 from shdehnavi/null_coalescing_conversion_tests 2023-09-09 09:51:17 +02:00
Côme Chilliet 8549ea4025
Merge pull request #40216 from nextcloud/print-log-message-when-version-could-not-be-got-from-updater-server
Print log message when version could not be got from updater server
2023-09-07 09:33:06 +02:00
Daniel Calviño Sánchez 9a179c391e Print log message when version could not be got from updater server
This could help to diagnose why the updater server could not be reached,
as well as other subtler issues like requests taking too long if the
updater server was tried to be connected to as a "side effect" (for
example, when the "updatenotification" app boots).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-09-06 05:43:21 +02:00
julia.kirschenheuter 8b6029564e Create right table view
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-09-05 16:46:46 -07:00
Carl Schwan 3270b7f12e
Add batch methods in user backends
This allows for faster group search with significantly less DB traffic

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-09-05 16:56:47 +02:00
Côme Chilliet 637cafcf35
Fix ContactsManagerTest adressbook mocks having a null key
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 09:20:26 +02:00
Robin Appelman 64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper
move share permission logic to storage wrapper
2023-09-04 14:05:14 +02:00
Simon L 489a57e9a3
Merge pull request #39707 from nextcloud/bugfix/39706/local-ext-storage-unavailable-mode 2023-09-04 12:05:36 +02:00
John Molakvoæ (skjnldsv) f828dce597
Fix sharing creation insert and get
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-02 10:25:24 +02:00
Robin Appelman e704470c79
update tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-31 22:37:10 +02:00
Benjamin Gaussorgues 303dadfaa9
sharebymail: remove ILogger and upgrade to PHP 8 syntax
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-08-30 18:36:29 +02:00
Andrew Summers 6b09a79227
Refactor `OC\Server::getShareManager`
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2023-08-29 21:32:58 -05:00
Daniel Kesselberg eab46bdfe6
feat: add switch to disable dns pinning
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-29 18:03:54 +02:00
Vincent Petry 8d1a3daa3f Allow ext storage Local to go unavailable
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.

This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.

The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
2023-08-29 11:04:31 +02:00
Joas Schilling 6f520f2304
Merge pull request #40026 from lhsazevedo/auth-token-commands
feat: Add auth token list and delete commands
2023-08-29 08:57:07 +02:00
Lucas Azevedo 79bc6ba06c Merge branch 'master' into auth-token-commands 2023-08-28 12:25:01 -03:00
Joas Schilling 25309bcb45
techdebt(DI): Use public IThrottler interface which exists since Nextcloud 25
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-28 15:50:45 +02:00
Git'Fellow 066f6ef16c Stop sending deprecated Pragma header
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-08-28 15:11:22 +02:00
Côme Chilliet fd0de0a2d1 Fix tests, add test for the new feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-28 09:40:12 +02:00
Ferdinand Thiessen bd37607fc0 chore: Remove unused FilePickerContext from behat tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-26 20:56:09 +02:00
Lucas Azevedo 771a7b92cc Add tests for occ user:auth-tokens:delete
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-25 02:27:41 -03:00
Joas Schilling 124588d4a6
fix: Make bypass function public API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +02:00
Joas Schilling fd9b2d488e
feat: Expose if the own IP is allowed to bypass bruteforce protection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:04 +02:00
Joas Schilling a95800c647
feat(security): Add a bruteforce protection backend base on memcache
Similar to the ratelimit backend

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:03 +02:00
Jérôme Herbinet 2ace681a2a
Download and enable all
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Download and enable all

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

npm run build

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-08-18 22:51:12 +02:00
Robin Appelman b6c3507aa0 only determine quota_include_external_storage once for quota wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-18 14:25:28 +02:00
John Molakvoæ 74c2f61cbd
chore: remove outdated acceptance tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 19:55:36 +02:00
John Molakvoæ 266fb31180
fix(tests): preview phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:58:21 +02:00
John Molakvoæ 998b3a2581
feat(f2v): migrate Files
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:56:37 +02:00
Hamid Dehnavi 271e63e41c Convert isset ternary to null coalescing operator
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-08-17 01:36:50 +02:00
Robin Appelman e73889a240 cleanup di for share permissions wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-16 15:25:05 +02:00
Ferdinand Thiessen 5b37d6d9ff tests: Add test for CacheEntry getters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-16 14:00:21 +02:00
Côme Chilliet f57c12b14e
Fix various deprecation warnings in tests on PHP 8.3
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-14 18:13:12 +02:00
Côme Chilliet ee756579a7
Fix setting static property in tests on PHP 8.3
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-14 16:27:56 +02:00
Joas Schilling 9fb08f506f
Merge pull request #38082 from nextcloud/allow-wasm-unsafe-eval-in-csp
Allow "wasm-unsafe-eval" in CSP
2023-08-11 14:04:49 +02:00
Daniel Calviño Sánchez 41f2d912d2 Allow "wasm-unsafe-eval" in CSP
If a page has a Content Security Policy header and the `script-src` (or
`default-src`) directive does not contain neither `wasm-unsafe-eval` nor
`unsafe-eval` loading and executing WebAssembly is blocked in the page
(although it is still possible to load and execute WebAssembly in a
worker thread).

Although the Nextcloud classes to manage the CSP already supported
allowing `unsafe-eval` this affects not only WebAssembly, but also the
`eval` operation in JavaScript.

To make possible to allow WebAssembly execution without allowing
JavaScript `eval` this commit adds support for allowing
`wasm-unsafe-eval`.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-08-10 02:38:41 +02:00
Daniel Kesselberg d56e2aad74 test: remove broken steps from files acceptance test
The acceptance tests using the recent view fail since the vue migration.

`And I open the details view for "welcome.txt"`

Is looking for a row in the filelist with a span having the class nametext, matching the file name "welcome.txt" and button inside having the class action-menu.

The markup for the files list looks very different after the vue migration and therefor the test is failing.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-09 20:58:29 +02:00
Julien Veyssier f099aa2714
Merge branch 'master' into fix/llm-migration-not-executed 2023-08-07 13:26:39 +02:00
Marcel Klehr f62711d2ae Fix TextProcessing test for 32bit
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-07 12:03:11 +02:00
Joas Schilling 3bd8f8c1db
Merge pull request #39705 from nextcloud/fix/noid/adjust-integrity-test-for-updated-mime-mappings
fix: adjust test for font icon
2023-08-04 10:42:08 +02:00
Joas Schilling 44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup
fix!: Final round of moving to IEventDispatcher
2023-08-04 10:39:57 +02:00
Daniel Kesselberg e0c8d58dd1
fix: adjust test for font icon
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-04 00:01:25 +02:00
Daniel Kesselberg 0098af3b98
fix: missing argument for TextProcessing Manager
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-03 00:33:00 +02:00
Ferdinand Thiessen e457572f6b fix: Acceptance tests adjusted to find new style sidebar tabs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-02 15:21:34 +02:00
John Molakvoæ 38480fda3c
feat(files_external): migrate to vue
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-01 16:38:06 +02:00
Joas Schilling b9e2f494a1
chore!: Remove legacy SymfonyAdapter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:22 +02:00
Joas Schilling cebf93d4d2
fix: Remove legacy dispatcher from share manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +02:00
Joas Schilling 8ad94cbfda
feat!: Migrate unShare events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +02:00
Joas Schilling 44b810bfbd
feat!: Migrate Sharing events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +02:00
Joas Schilling 68fc9b48c2
feat!: Migrate AccountManager event to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +02:00
Marcel Klehr 7e790a3297 JobTest: Remove outdated tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +02:00
Marcel Klehr 3d8fd2d99e cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +02:00
Marcel Klehr 449a731375 Add test for ParallelAwareJob
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +02:00
Joas Schilling 030e8d8916
fix: Align doc type with creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:38 +02:00
Joas Schilling 80f79e170d
fix!: Remove symfony EventDispatcherInterface from Group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +02:00
Joas Schilling ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +02:00
Joas Schilling 6b7221756c
Merge pull request #39571 from nextcloud/bugfix/noid/move-lib-to-IEventDispatcher
Move lib/ events to IEventDispatcher where possible
2023-07-27 18:59:42 +02:00
Daniel Kesselberg 68eecca4d4 chore: update expected results for CLDR 42
Punic 3.8.0 / CLDR 42 added a narrow no-break space unicode character for the time formats and a new default pattern for datetime.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +02:00
Daniel Kesselberg 06248cda0a chore: update expected timezone from GMT+0 to UTC
Punic 3.2.0 added support for timezone translations and returns UTC instead of GMT+0 now.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +02:00
Joas Schilling c67c067ee7
fix: Move Sharing events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +02:00
Joas Schilling 44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +02:00
Joas Schilling 6953e14580
fix: Move SystemTags events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +02:00
Joas Schilling dac31ad101
fix!: Remove legacy event dispatching Symfony's GenericEvent from 2FA Manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +02:00
Joas Schilling 1b387bb341
fix!: Remove legacy event dispatching Symfony's GenericEvent from AdditionalScripts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +02:00
Joas Schilling 5bb6a7804f
fix: Move AppManager events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +02:00
Joas Schilling 4f7de8ed60
fix!: Remove legacy event dispatching Symfony's GenericEvent
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +02:00
Joas Schilling 7548e62181
Merge pull request #39506 from nextcloud/techdebt/39488/ensure-index-name-uniqueness
feat(db): Ensure that index names are unique across the database
2023-07-24 14:44:37 +02:00
Joas Schilling b80692d323
fix(tests): Adjust unit tests to outline the schema is checked twice now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-21 12:17:36 +02:00
Marcel Klehr 7c80d66ee5
Merge pull request #38854 from nextcloud/enh/llm-api 2023-07-21 11:20:31 +02:00
Benjamin Gaussorgues e9b8a34cce
Merge pull request #39264 from nextcloud/feat/add-instance-category
Add instance category while checking new updates
2023-07-21 11:04:32 +02:00
Benjamin Gaussorgues 31f1354777
Add instance category while checking new updates
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-18 15:39:23 +02:00
Ferdinand Thiessen 3b057600d0 fix: Correctly add `module` content type to script tags when scripts with versions are used
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-18 13:10:37 +02:00
Marcel Klehr ffe27ce14c Massive refactoring: Turn LanguageModel OCP API into TextProcessing API
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-14 16:00:31 +02:00
Joas Schilling d5ee076017
Merge pull request #39329 from nextcloud/feat/phpunit-for-css-generated-file
fix: also run phpunit on `apps/theming/css` modified files
2023-07-13 17:58:26 +02:00
Robin Appelman c988d782eb
Merge pull request #39331 from nextcloud/feature/openapi/core
core: Add OpenAPI spec
2023-07-13 15:36:51 +02:00
jld3103 1be836273d
core: Add OpenAPI spec
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-13 07:24:15 +02:00
Christopher Ng faf2b2339d test(settings): Users table
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-07-12 21:35:55 -07:00
Christopher Ng 8faa1a4fe7 fix(acceptance): UsersSettingsContext
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-07-12 21:35:55 -07:00
John Molakvoæ 48e47c6a46
fix: also run phpunit on `apps/theming/css` modified files
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-12 09:25:39 +02:00
Joas Schilling 2c6f32cb28
feat(request): Allow to match the client version with the IRequest::USER_AGENT_* regex
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-11 07:35:50 +02:00
Marcel Klehr bf2dcd67f3 LLM OCP API: Change Tests to use EventDispatcher mock
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +02:00
Marcel Klehr d56286b8ac LLM OCP API: s/getAvailableTasks/getAvailableTaskClasses/
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +02:00
Marcel Klehr c568c4a464 Add test for task cleanup
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +02:00
Marcel Klehr 20cb9935ca Fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +02:00
Marcel Klehr ebc7631544 Add preliminary tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +02:00
Joas Schilling 05aa39d777
Fix event names of 2FA related typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-03 14:25:01 +02:00
Ferdinand Thiessen 97683a5b66 fix(settings): Migrate away from deprecated `NcPopoverMenu`
* Replace popover menu with `NcActions`
* Deduplicate user actions code between `UserRow` and `UserRowSimple`
* Fix user action to cover whole row heigh to prevent dropdown from shining through the actions
* Fix user action popover to be overlayed by current edited row actions

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-30 11:38:11 -07:00
jld3103 b0001c6010
Add template types to responses
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-30 09:33:29 +02:00
Ferdinand Thiessen 5e81a9e53d fix: Add cypress test for changing password in the users list
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-29 00:08:21 +02:00
julia.kirschenheuter 3fba4c5529 Replace plain input fields with NcTextField fields and NcMultiSelect fields with NcSelect fields
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-06-28 21:53:12 +02:00
Joas Schilling ec6728d710
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 15:53:57 +02:00
Daniel 9751303182
Merge pull request #38679 from nextcloud/feat/add-spec-to-preview-fetched-event
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
2023-06-26 13:53:27 +02:00
Côme Chilliet 783f1b9a2a
Merge pull request #38775 from fsamapoor/constructor_property_promotion_in_core_command_part9
Uses PHP8's constructor property promotion in core/Command and /
2023-06-26 10:38:06 +02:00
Simon L f7183c9dcf
Merge pull request #38958 from nextcloud/enh/noid/use-getsystemvalue-mailer
use getsystemvalue-functions in Mailer.php
2023-06-26 10:23:29 +02:00
Faraz Samapoor fd0e2f711a Fixes testcase error.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-24 23:14:23 +02:00
Arthur Schiwon 17515995fa
Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type
fix: expect interface, not a specific implementation
2023-06-24 00:13:43 +02:00
Simon L 1cb81ae625 try to fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-23 17:12:45 +02:00
Daniel Kesselberg 440f882322
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
user_usage_report keeps a counter for files read.

The app uses

- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT

Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-23 16:27:35 +02:00
Joas Schilling a3fe1adb03
Merge pull request #38917 from nextcloud/bugfix/talk-9558/plural-issue-with-some-language-locale-combinations
fix(l10n): Fix plural issue with different locale and language
2023-06-22 09:17:48 +02:00
Christopher Ng 84ff000767 enh(a11y): New user modal
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-06-21 11:12:40 -07:00
Arthur Schiwon f6ac874dbf
chore: ugly type juggling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +02:00
John Molakvoæ f8e697ce4d
feat: prepare jest upgrade and ts testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +02:00
Joas Schilling ab8205fd35
fix(l10n): Fix plural issue with different locale and language
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-21 07:14:56 +02:00
jld3103 7f4651637a
Allow stdClass in XML responses
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-13 11:44:47 +02:00
Christoph Wurst 08a3f37695
chore(appframework)!: Drop \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 10:03:59 +02:00
Arthur Schiwon ffa30ce89b
Merge pull request #38524 from nextcloud/chore/app/clear-unused-cache-key
chore(app): Do not clear unused cache key
2023-06-05 17:48:44 +02:00
Daniel Kesselberg a2afc7b6a9
refactor: migrate OC_EventSource to dependency injection
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-03 21:42:51 +02:00
Joas Schilling 6d076c1ee9
fix(dispatcher): Migrate to OCP event dispatcher before symfony/event-dispatcher upgrade
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-02 08:08:24 +02:00
Christoph Wurst e76d525a43
chore: Drop \OC_App::getAppInfo
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +02:00
Christoph Wurst cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +02:00
Christoph Wurst 315f7f286f
chore: Drop app code checker test data
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-31 14:57:57 +02:00
Christoph Wurst 3d1acca1f3
chore(app): Do not clear unused cache key
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-30 17:48:20 +02:00
julia.kirschenheuter 94e1a429e5 Revert "Fix table view"
This reverts commit cb852ef6

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-25 11:49:24 +02:00
Simon L 3d2d1c171e
Merge pull request #37758 from nextcloud/redis-atomic
redis: use atomic operations everywhere
2023-05-19 23:29:24 +02:00
Simon L 48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache
Fix generated avatars cache
2023-05-16 11:37:49 +02:00
Joas Schilling 5e02def3f4
Merge pull request #38274 from nextcloud/bugfix/noid/reach-max-delay-in-afterController
fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:07:04 +02:00
jld3103 2a19753cf7
Clear generated avatar caches
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-15 18:18:21 +02:00
Joas Schilling 3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:20:19 +02:00
Joas Schilling 33385d7ecb
fix(tests): Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:12:14 +02:00
John Molakvoæ 174c226c28
Merge pull request #38207 from nextcloud/fix/jsresourcelocator-l10n-handling 2023-05-12 10:47:46 +02:00
Ferdinand Thiessen 31c01fa3da fix(JSResourceLocator): Handle missing translations silently
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-11 18:22:24 +02:00
julia.kirschenheuter cb852ef63b Fix table view
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-11 16:36:37 +02:00
John Molakvoæ db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan 2023-05-11 08:15:41 +02:00
Varun Patil c6cee282b3 redis: move lua scripts to class and add type hints
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-10 17:37:02 -07:00
Robin Appelman 2ea41dab93
repair -1 folder sizes for object store background scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-10 19:33:26 +02:00
Robin Appelman 904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http
log performance events for http requests
2023-05-09 17:15:27 +02:00
Joas Schilling b91957e3df
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-03 22:43:36 +02:00
Arthur Schiwon 7fcf42ad3f
Merge pull request #38024 from nextcloud/fix/fix-32bits-ci
Fix 32bits ci
2023-05-03 10:34:04 +02:00
Arthur Schiwon ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date
Update expire_date column of table comments
2023-05-03 10:26:28 +02:00
Côme Chilliet e252182d80
Put back file cleanups, and remove dead code in tests/lib/Template/JSResourceLocatorTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:24:28 +02:00
Côme Chilliet adf743b141
Remove the array_pop failing tests on 32bit CI
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:09:37 +02:00
Côme Chilliet 10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates
Also went back to searchUsers indexing the array by uid as it was the
 previous behavior and the IGroup phpdoc does not say anything about the
 keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 11:35:41 +02:00
Robin Appelman e7ab30f5d8
log performance events for http requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:37:57 +02:00
Côme Chilliet b6c17c6ce7
Clear up return types
usersInGroup index by int for BC, searchInGroup index by uid (string).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +02:00
Carl Schwan 35dc223500
Optimize retrieving display name when searching for users in a group
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +02:00
Vitor Mattos 5ed6722dd2 Cover expire_date with unit tests
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-04-26 13:21:08 -03:00
Joas Schilling 75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations
feat(security): Add PHP \Attribute for remaining security annotations
2023-04-25 17:13:53 +02:00
Joas Schilling ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-25 14:50:32 +02:00
Côme Chilliet 7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs
feat(BackgroundJobs): Allow preventing parallel runs for a job class
2023-04-25 12:10:43 +02:00
Marcel Klehr 06d6cf4ebc JobListTest: Fix JobList constructor call
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 19:07:13 +02:00
Marcel Klehr 6148c5e0a1
Update tests/lib/BackgroundJob/DummyJobList.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 12:35:52 +02:00
Joas Schilling 89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-24 12:24:48 +02:00
Marcel Klehr a0c722ad69 Run cs:Fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +02:00
Marcel Klehr 5608b50778 Fix BackgroundJob tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +02:00
Marcel Klehr 281c8047b6 JobListTest: clearJobsList before testHasReservedJobs
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +02:00
Marcel Klehr 56cb5d1d13 fix(tests): Remove duplicated method
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +02:00
Marcel Klehr 1296f3612e test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +02:00
Côme Chilliet b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-20 16:52:38 +02:00
Joas Schilling b62c49f1e0
Merge pull request #37795 from nextcloud/techdebt/noid/improve-ci
fix(CI): Disable unstable test until someone can have a look at it
2023-04-18 21:07:38 +02:00
Christoph Wurst 2c0cfd3772
feat(app-framework): Add native argument types for middleware
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-18 17:15:05 +02:00
Joas Schilling 6ac8052896
fix(CI): Disable unstable test until someone can have a look at it
Passes locally 100% and on CI 50% of the time

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-18 13:59:35 +02:00
Simon L 8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container
chore: Update PSR container to 2.0.2
2023-04-18 11:40:12 +02:00
Julius Härtl d9c81f56ad tests: Adapt node related unit tests mocks to required root view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +02:00
Julius Härtl 160bd75d0a fix: Use proper path when creating node instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +02:00
Ferdinand Thiessen dc9d8c42bb fix: Adjust console formatter code to match with Symfony type hints
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +02:00
Glandos 384a1d34a8 adapt test to new workflow
getDirectoryListing should return all files
getFile is not called anymore

Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Robin Appelman 0375c9866c
add test to verify redis lua script hashes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:18:48 +02:00
jld3103 b153340b62
Add type hints for mappers
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-07 09:49:42 +02:00
John Molakvoæ 5b3900e849
fix(tests): acceptance
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-06 15:43:30 +02:00
Arthur Schiwon 1ac7a3f107
Merge pull request #37595 from jtrees/add-some-tests-to-lost-controller
Add some tests for input trimming in LostController.php
2023-04-06 11:12:52 +02:00
Côme Chilliet 8d5165e8dc
Adapt tests to config value typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:42:14 +02:00
Joshua Trees a4032a3800 Add some tests for input trimming in LostController.php
Signed-off-by: Joshua Trees <me@jtrees.io>
2023-04-05 12:15:38 +02:00
Côme Chilliet 8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup
Tidy up typing in OC\Files\View
2023-04-05 10:14:55 +02:00
jld3103 d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +02:00
Joas Schilling 131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-04 10:54:12 +02:00
Louis 7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value
Migrate metadata JSON column to new value TEXT column
2023-04-04 10:23:54 +02:00
Joas Schilling c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 14:19:41 +02:00
Louis Chemineau 1a6709cf43 Migrate metadata as JSON to value as STRING
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +02:00
Côme Chilliet 4393b96542
Remove unused method getLocalFolder
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +02:00
Côme Chilliet 966a3e6963
Tidy up typing in OC\Files\View
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +02:00
Joas Schilling 454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 09:06:45 +02:00
Arthur Schiwon 997c2a2a79
fix DBAL exception handling in setValues
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 17:01:17 +02:00
Christopher Ng 4f8e916585 Add label for logo link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 -07:00
Git'Fellow 346054f854
Fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-28 09:41:04 +02:00
Julius Härtl 8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts 2023-03-22 09:17:28 +01:00
Côme Chilliet 633ea018af
Fix BackgroundCleanupJobTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:44 +01:00
Joas Schilling bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
2023-03-16 19:33:13 +01:00
Arthur Schiwon a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection
chore: use local variable for remote address
2023-03-15 15:11:53 +01:00
Artur Neumann 37cfccabc1
unit tests for Manager::invalidateTokensOfUser
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-03-14 17:13:30 +01:00
Côme Chilliet 71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
2023-03-13 22:10:47 +01:00
Côme Chilliet 9b1d7794a8 Add chunking in SystemTagObjectMapper::getTagIdsForObjects
This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-13 17:36:10 +00:00
Thomas Citharel f1751c4428
Introduced app enable/disable/update typed events
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +01:00
Daniel Kesselberg 39c1b6f49f
chore(tests): add tests for handleLoginFailed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-10 18:04:39 +01:00
Joas Schilling 2b49861679
Add a debug message when throttling without defining
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +01:00
Joas Schilling e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +01:00
Joas Schilling b4f51fe728
fix(CI): Fix acceptance test password field selector after @nextcloud/vue lib update
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-07 09:34:47 +01:00
Joas Schilling c297f8ee96
feat(appframework): Make ITimeFactory extend \PSR\Clock\ClockInterface
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 15:37:13 +01:00
Joas Schilling de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database
Split the comments ids by chunks
2023-03-03 12:37:15 +01:00
blizzz 289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments
[db]: Remove not supported column comments for SQLite
2023-03-02 12:10:19 +01:00
Vitor Mattos e9295f739e Split the comments ids by chunks
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.

https://github.com/nextcloud/spreed/issues/8287

Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-03-01 13:08:17 -03:00
John Molakvoæ 0b966ab200
Merge pull request #36471 from nextcloud/fix/theming-keep-images 2023-03-01 09:54:49 +01:00
Ferdinand Thiessen 1785a80754 tests(db): Add test case to ensure column comments work
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-28 10:39:13 +01:00
Marcel Klehr 4f7d77406d Fix SystemTagManagerTest#createTag test
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:40:33 +01:00
Marcel Klehr 889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:22:41 +01:00
Marcel Klehr 8151b1b8b0 fix(SystemTagManager): Truncate overlong tag names
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 12:55:10 +01:00
Ferdinand Thiessen b642137c65 feat(OC/Template): Add `type="module"` for ES6 scripts
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +01:00
Ferdinand Thiessen 00e041b907 feat(template): Allow `JSResourceLocator` to find ES6 scripts
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +01:00
Joas Schilling 98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +01:00
Ferdinand Thiessen 61b9ba28e4 Add webp and large jpg test assets
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-20 13:11:19 +01:00
Julius Härtl 614981ae9a
feat(directediting): Allow opening by file id
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +01:00
Anna Larch 5d4efb4d5f
Do not set up filesystem on every call
Also remove old Oc_FileChunking logis that produced GC- collectable chunks

Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +01:00
Julius Härtl 47bc024885
Revert the token scope to not end up with storing the user used in the session
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +01:00
Julius Härtl 90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors 2023-02-17 09:42:08 +01:00
Ferdinand Thiessen f655f83c84 fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-16 22:55:18 +01:00
Louis 98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts
fix the contacts-menu vcf-contact avatars
2023-02-16 14:01:19 +01:00