Don't leak X509_OBJECT in an error path

Swap the ordering of some code to avoid a leak in an error path.

Reviewed-by: Richard Levitte <levitte@openssl.org>
This commit is contained in:
Matt Caswell 2016-04-26 18:25:39 +01:00
parent 6493e4801e
commit 0461b7ea7b
1 changed files with 3 additions and 3 deletions

View File

@ -576,13 +576,13 @@ static int cert_status_cb(SSL *s, void *arg)
BIO_puts(bio_err, "cert_status: Can't retrieve issuer certificate.\n");
goto done;
}
req = OCSP_REQUEST_new();
if (req == NULL)
goto err;
id = OCSP_cert_to_id(NULL, x, X509_OBJECT_get0_X509(obj));
X509_OBJECT_free(obj);
if (!id)
goto err;
req = OCSP_REQUEST_new();
if (req == NULL)
goto err;
if (!OCSP_request_add0_id(req, id))
goto err;
id = NULL;