From 2497e2e7dbe54420cd98dc2ff013ed5886cd4d8e Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Sun, 10 Jan 2021 09:26:22 +0100 Subject: [PATCH] Configure: warn about duplicate GENERATE declarations in build.info files This sort of duplication is permitted, as the end result will be a single item anyway, but we might as well warn to avoid future confusion. Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/13824) --- Configure | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Configure b/Configure index 87267e2a26..ccdb037de2 100755 --- a/Configure +++ b/Configure @@ -2325,7 +2325,7 @@ EOF if ($generate{$gen}) { $generator[0] = cleanfile($buildd, $gen, $blddir); } - $check_generate{$ddest}->{$generator[0]} = 1; + $check_generate{$ddest}->{$generator[0]}++; $unified_info{generate}->{$ddest} = [ @generator ]; } @@ -2439,6 +2439,9 @@ EOF warn "$_ is GENERATEd by more than one generator ($generators_txt)\n"; $ambiguous_generation++; } + if ($check_generate{$_}->{$generators[0]} > 1) { + warn "INFO: $_ has more than one GENERATE declaration (same generator)\n" + } } die "There are ambiguous source file generations\n" if $ambiguous_generation > 0;