openssl
/
openssl
mirror of https://github.com/openssl/openssl
1
0
Fork 0
Code Issues Releases Wiki Activity

Make secure-memory be a config option 

Adding support for "no-secure-memory" was simple, a one-liner.
Fixing all the "ifdef OPENSSL_SECURE_MEMORY" to be "ifndef NO_xxx"
was a bit more work.  My original goof, for not following the OpenSSL
pattern "ifndef NO_" used everywhere else.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/11023)
This commit is contained in:
Rich Salz 2020-02-05 14:28:37 -05:00 committed by Bernd Edlinger
parent cdb1663263
commit 6943335e3e
4 changed files with 36 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Configure
View File

@ -412,6 +412,7 @@ my @disablables = (
"rmd160", "rmd160",
"scrypt", "scrypt",
"sctp", "sctp",
"secure-memory",
"seed", "seed",
"shared", "shared",
"siphash", "siphash",

45
crypto/mem_sec.c
View File

@ -20,8 +20,7 @@
#include <string.h> #include <string.h>
/* e_os.h defines OPENSSL_SECURE_MEMORY if secure memory can be implemented */ #ifndef OPENSSL_NO_SECURE_MEMORY
#ifdef OPENSSL_SECURE_MEMORY
# include <stdlib.h> # include <stdlib.h>
# include <assert.h> # include <assert.h>
# include <unistd.h> # include <unistd.h>
@ -47,7 +46,7 @@
# define MAP_ANON MAP_ANONYMOUS # define MAP_ANON MAP_ANONYMOUS
#endif #endif
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
static size_t secure_mem_used; static size_t secure_mem_used;
static int secure_mem_initialized; static int secure_mem_initialized;
@ -67,7 +66,7 @@ static int sh_allocated(const char *ptr);
int CRYPTO_secure_malloc_init(size_t size, size_t minsize) int CRYPTO_secure_malloc_init(size_t size, size_t minsize)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
int ret = 0; int ret = 0;
if (!secure_mem_initialized) { if (!secure_mem_initialized) {
@ -85,12 +84,12 @@ int CRYPTO_secure_malloc_init(size_t size, size_t minsize)
return ret; return ret;
#else #else
return 0; return 0;
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
int CRYPTO_secure_malloc_done(void) int CRYPTO_secure_malloc_done(void)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
if (secure_mem_used == 0) { if (secure_mem_used == 0) {
sh_done(); sh_done();
secure_mem_initialized = 0; secure_mem_initialized = 0;
@ -98,22 +97,22 @@ int CRYPTO_secure_malloc_done(void)
sec_malloc_lock = NULL; sec_malloc_lock = NULL;
return 1; return 1;
} }
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
return 0; return 0;
} }
int CRYPTO_secure_malloc_initialized(void) int CRYPTO_secure_malloc_initialized(void)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
return secure_mem_initialized; return secure_mem_initialized;
#else #else
return 0; return 0;
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
void *CRYPTO_secure_malloc(size_t num, const char *file, int line) void *CRYPTO_secure_malloc(size_t num, const char *file, int line)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
void *ret; void *ret;
size_t actual_size; size_t actual_size;
@ -128,12 +127,12 @@ void *CRYPTO_secure_malloc(size_t num, const char *file, int line)
return ret; return ret;
#else #else
return CRYPTO_malloc(num, file, line); return CRYPTO_malloc(num, file, line);
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
void *CRYPTO_secure_zalloc(size_t num, const char *file, int line) void *CRYPTO_secure_zalloc(size_t num, const char *file, int line)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
if (secure_mem_initialized) if (secure_mem_initialized)
/* CRYPTO_secure_malloc() zeroes allocations when it is implemented */ /* CRYPTO_secure_malloc() zeroes allocations when it is implemented */
return CRYPTO_secure_malloc(num, file, line); return CRYPTO_secure_malloc(num, file, line);
@ -143,7 +142,7 @@ void *CRYPTO_secure_zalloc(size_t num, const char *file, int line)
void CRYPTO_secure_free(void *ptr, const char *file, int line) void CRYPTO_secure_free(void *ptr, const char *file, int line)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
size_t actual_size; size_t actual_size;
if (ptr == NULL) if (ptr == NULL)
@ -160,13 +159,13 @@ void CRYPTO_secure_free(void *ptr, const char *file, int line)
CRYPTO_THREAD_unlock(sec_malloc_lock); CRYPTO_THREAD_unlock(sec_malloc_lock);
#else #else
CRYPTO_free(ptr, file, line); CRYPTO_free(ptr, file, line);
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
void CRYPTO_secure_clear_free(void *ptr, size_t num, void CRYPTO_secure_clear_free(void *ptr, size_t num,
const char *file, int line) const char *file, int line)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
size_t actual_size; size_t actual_size;
if (ptr == NULL) if (ptr == NULL)
@ -187,12 +186,12 @@ void CRYPTO_secure_clear_free(void *ptr, size_t num,
return; return;
OPENSSL_cleanse(ptr, num); OPENSSL_cleanse(ptr, num);
CRYPTO_free(ptr, file, line); CRYPTO_free(ptr, file, line);
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
int CRYPTO_secure_allocated(const void *ptr) int CRYPTO_secure_allocated(const void *ptr)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
int ret; int ret;
if (!secure_mem_initialized) if (!secure_mem_initialized)
@ -203,21 +202,21 @@ int CRYPTO_secure_allocated(const void *ptr)
return ret; return ret;
#else #else
return 0; return 0;
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
size_t CRYPTO_secure_used(void) size_t CRYPTO_secure_used(void)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
return secure_mem_used; return secure_mem_used;
#else #else
return 0; return 0;
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */
} }
size_t CRYPTO_secure_actual_size(void *ptr) size_t CRYPTO_secure_actual_size(void *ptr)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
size_t actual_size; size_t actual_size;
CRYPTO_THREAD_write_lock(sec_malloc_lock); CRYPTO_THREAD_write_lock(sec_malloc_lock);
@ -235,7 +234,7 @@ size_t CRYPTO_secure_actual_size(void *ptr)
/* /*
* SECURE HEAP IMPLEMENTATION * SECURE HEAP IMPLEMENTATION
*/ */
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
/* /*
@ -642,4 +641,4 @@ static size_t sh_actual_size(char *ptr)
OPENSSL_assert(sh_testbit(ptr, list, sh.bittable)); OPENSSL_assert(sh_testbit(ptr, list, sh.bittable));
return sh.arena_size / (ONE << list); return sh.arena_size / (ONE << list);
} }
#endif /* OPENSSL_SECURE_MEMORY */ #endif /* OPENSSL_NO_SECURE_MEMORY */

17
e_os.h
View File

@ -299,11 +299,16 @@ struct servent *getservbyname(const char *name, const char *proto);
# define CRYPTO_memcmp memcmp # define CRYPTO_memcmp memcmp
# endif # endif
/* unistd.h defines _POSIX_VERSION */ # ifndef OPENSSL_NO_SECURE_MEMORY
# if !defined(OPENSSL_NO_SECURE_MEMORY) && defined(OPENSSL_SYS_UNIX) \ /* unistd.h defines _POSIX_VERSION */
&& ( (defined(_POSIX_VERSION) && _POSIX_VERSION >= 200112L) \ # if defined(OPENSSL_SYS_UNIX) \
|| defined(__sun) || defined(__hpux) || defined(__sgi) \ && ( (defined(_POSIX_VERSION) && _POSIX_VERSION >= 200112L) \
|| defined(__osf__) ) || defined(__sun) || defined(__hpux) || defined(__sgi) \
# define OPENSSL_SECURE_MEMORY /* secure memory is implemented */ || defined(__osf__) )
/* secure memory is implemented */
# else
# define OPENSSL_NO_SECURE_MEMORY
# endif
# endif # endif
#endif #endif

4
test/secmemtest.c
View File

@ -14,7 +14,7 @@
static int test_sec_mem(void) static int test_sec_mem(void)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
int testresult = 0; int testresult = 0;
char *p = NULL, *q = NULL, *r = NULL, *s = NULL; char *p = NULL, *q = NULL, *r = NULL, *s = NULL;
@ -135,7 +135,7 @@ static int test_sec_mem(void)
static int test_sec_mem_clear(void) static int test_sec_mem_clear(void)
{ {
#ifdef OPENSSL_SECURE_MEMORY #ifndef OPENSSL_NO_SECURE_MEMORY
const int size = 64; const int size = 64;
unsigned char *p = NULL; unsigned char *p = NULL;
int i, res = 0; int i, res = 0;