reiseburo
/
hermann
mirror of https://github.com/reiseburo/hermann
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix use-after-free bug 

it's not safe to simply pluck strings off the heap unless we were also
going to maintain a reference to them.  sidestep this problem by
strdup'ing the topic and brokers strings
This commit is contained in:
Ben Osheroff 2015-04-29 14:33:58 -07:00
parent a3d8998a6f
commit 30669be4d5
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ext/hermann/hermann_lib.c
View File

@ -762,6 +762,9 @@ static void consumer_free(void *p) {
rd_kafka_destroy(config->rk);
}
free(config->topic);
free(config->brokers);
// clean up the struct
free(config);
}
@ -837,8 +840,8 @@ static VALUE consumer_initialize(VALUE self,
partitionNo = FIX2INT(partition);
Data_Get_Struct(self, HermannInstanceConfig, consumerConfig);
consumerConfig->topic = topicPtr;
consumerConfig->brokers = brokersPtr;
consumerConfig->topic = strdup(topicPtr);
consumerConfig->brokers = strdup(brokersPtr);
consumerConfig->partition = partitionNo;
consumerConfig->run = 1;
consumerConfig->exit_eof = 0;