reiseburo/rx-curator
1
0
Fork 0
mirror of https://github.com/reiseburo/rx-curator synced 2024-09-15 06:41:58 +00:00
Code Issues Releases Wiki Activity

Properly handle unsubscriptions and close our PathChildrenCache object out

Browse Source
This commit is contained in:
R. Tyler Croy 2015-09-04 12:36:30 -07:00
parent a1c7147c5e
commit 10ada1646f
No known key found for this signature in database
GPG Key ID: 1426C7DC3F51E16F
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/main/java/com/github/reiseburo/rx/curator/PathChildren.java
View File

@ -6,6 +6,9 @@ import org.apache.curator.framework.recipes.cache.PathChildrenCacheEvent;
import org.apache.curator.framework.recipes.cache.PathChildrenCacheListener;
import rx.Observable;
import rx.Subscriber;
import rx.functions.Action0;
import java.io.IOException;
/**
* PathChildren is an {@code Observable} which takes events from a {@code PathChildrenCache}
@ -49,8 +52,7 @@ public class PathChildren {
cache = new PathChildrenCache(curatorFramework, znodePath, true);
try {
cache.start(PathChildrenCache.StartMode.POST_INITIALIZED_EVENT);
}
catch (Exception ex) {
} catch (Exception ex) {
subscriber.onError(ex);
}
@ -61,6 +63,19 @@ public class PathChildren {
}
});
}
}).doOnUnsubscribe(new Action0() {
@Override
public void call() {
/* properly close out our cache object when our subscriber leaves */
if (cache instanceof PathChildrenCache) {
try {
cache.close();
} catch (IOException exception) {
/* Swallow, we don't need this exception */
}
}
}
});
}
}

4
src/test/groovy/com/github/reiseburo/rx/curator/PathChildrenSpec.groovy
View File

@ -58,12 +58,14 @@ class PathChildrenIntegrationSpec extends Specification {
def "an initialization event should be received"() {
given:
boolean received = false
Subscription subscription
Observable<PathChildrenCacheEvent> observable = PathChildren.with(curator).watch('/')
when:
observable.subscribe { PathChildrenCacheEvent ev ->
subscription = observable.subscribe { PathChildrenCacheEvent ev ->
if (ev.type == PathChildrenCacheEvent.Type.INITIALIZED) {
received = true
subscription.unsubscribe()
}
}