reiseburo
/
whoas
mirror of https://github.com/reiseburo/whoas
1
0
Fork 0
Code Issues Releases Wiki Activity

Instead of logging exception, pass exception object to logger API 

References #9 and #23
This commit is contained in:
Mahesh V Kelkar 2015-03-24 13:53:20 -04:00 committed by R. Tyler Croy
parent 83809fe156
commit 1f623174b1
13 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/html5/groovydoc/com/github/lookout/whoas/AbstractHookQueue.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>AbstractHookQueue (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/AbstractHookRunner.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>AbstractHookRunner (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/HookRequest.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>HookRequest (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/InMemoryQueue.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>InMemoryQueue (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/Publisher.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>Publisher (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/RedisQueue.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>RedisQueue (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/SequentialHookRunner.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>SequentialHookRunner (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/WhoasConfiguration.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>WhoasConfiguration (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/WhoasFactory.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>WhoasFactory (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

2
docs/html5/groovydoc/com/github/lookout/whoas/WhoasQueueConfig.html
View File

@ -6,7 +6,7 @@
<html>
<head>
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 11:06:14 EDT 2015 -->
<!-- Generated by groovydoc (2.4.0) on Tue Mar 24 13:53:10 EDT 2015 -->
<title>WhoasQueueConfig (whoas 0.1.5 API)</title>
<meta name="date" content="2015-03-24">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

3
src/main/groovy/com/github/lookout/whoas/InMemoryQueue.groovy
View File

@ -61,8 +61,7 @@ class InMemoryQueue extends AbstractHookQueue {
catch (Exception ex) {
/* Put this back on the tail end of the queue */
logger.info("\"Pop\" on in-memory queue failed with an exception: " +
ex.getMessage() + ", putting it back on tail-end")
logger.info("\"Pop\" on in-memory queue failed, putting it back on the tail-end", ex)
this.internalQueue.put(item)
throw ex
}

5
src/main/groovy/com/github/lookout/whoas/Publisher.groovy
View File

@ -44,8 +44,7 @@ class Publisher {
String responseBody = response.readEntity(String.class)
}
catch (ProcessingException exc) {
logger.warn("\"POST\" to url: \"${request.url}\" " +
"has failed with exception: " + exc.getMessage())
logger.warn("\"POST\" to url: \"${request.url}\" failed", exc)
retryableExc = true
}
@ -60,7 +59,7 @@ class Publisher {
return this.publish(request)
}
logger.debug("\"POST\" to url: \"${request.url}\" succeeded, ${logger.name}, ${logger.debugEnabled}")
logger.debug("\"POST\" to url: \"${request.url}\" succeeded")
return true
}

3
src/main/groovy/com/github/lookout/whoas/RedisQueue.groovy
View File

@ -127,8 +127,7 @@ class RedisQueue extends AbstractHookQueue {
action.call(request)
} catch (Exception ex) {
/* Put this back on the front of the queue */
logger.info("\"Pop\" on redis queue failed with an exception: " +
ex.getMessage() + ", pushing it back on front of the queue")
logger.info("\"Pop\" on redis queue failed, pushing it back on front of the queue", ex)
redisClient.lpush(this.queueConfig.key, messages.get(1))
throw ex
}