rtyler
/
blueocean-plugin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

JENKINS-38016# Create ApiRoutable extensions lazily - after all plugins are installed (#484)

This commit is contained in:
vivek 2016-09-07 22:54:09 -07:00 committed by GitHub
parent dfff029465
commit 0875637afb
1 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
blueocean-rest/src/main/java/io/jenkins/blueocean/rest/ApiHead.java
View File

@ -29,13 +29,7 @@ public final class ApiHead implements RootRoutable, Reachable {
private volatile BlueOceanUI blueOceanUI;
private final Map<String,ApiRoutable> apis = new HashMap<>();
public ApiHead() {
for ( ApiRoutable api : ExtensionList.lookup(ApiRoutable.class)) {
apis.put(api.getUrlName(),api);
}
}
private volatile Map<String,ApiRoutable> apis;
/**
* Search API
@ -71,6 +65,7 @@ public final class ApiHead implements RootRoutable, Reachable {
* @return {@link ApiRoutable} object
*/
public ApiRoutable getDynamic(String route) {
setApis();
StaplerRequest request = Stapler.getCurrentRequest();
String m = request.getMethod();
if(m.equalsIgnoreCase("POST") || m.equalsIgnoreCase("PUT") || m.equalsIgnoreCase("PATCH")) {
@ -114,4 +109,21 @@ public final class ApiHead implements RootRoutable, Reachable {
}
}
}
// Lazy initialize ApiRoutable(s), just so we have all of them
private void setApis(){
Map<String,ApiRoutable> apiMap = apis;
if(apiMap == null){
synchronized (this){
apiMap = apis;
if(apiMap == null){
Map<String,ApiRoutable> apiMapTmp = new HashMap<>();
for ( ApiRoutable api : ExtensionList.lookup(ApiRoutable.class)) {
apiMapTmp.put(api.getUrlName(),api);
}
apis = apiMap = apiMapTmp;
}
}
}
}
}