rtyler
/
blueocean-plugin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Get rid of React warning about duplicate/missing keys on test page (#372)

This commit is contained in:
Keith Zantow 2016-07-26 10:02:17 -04:00 committed by GitHub
parent 3b3cd1764e
commit 501e74db31
2 changed files with 21 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
blueocean-dashboard/src/main/js/components/testing/TestResults.jsx
View File

@ -116,31 +116,31 @@ export default class TestResult extends Component {
);
if (newFailures.length > 0) {
newFailureBlock = [
<h4>New failing - {newFailures.length}</h4>,
newFailures.map((t, i) => <TestCaseResultRow key={i} testCase={t} />),
];
newFailureBlock = (<div className="test-result-block new-failure-block">
<h4>New failing - {newFailures.length}</h4>
{newFailures.map((t, i) => <TestCaseResultRow key={i} testCase={t} />)}
</div>);
}
if (existingFailures.length > 0) {
existingFailureBlock = [
<h4>Existing failures - {existingFailures.length}</h4>,
existingFailures.map((t, i) => <TestCaseResultRow key={i} testCase={t} />),
];
existingFailureBlock = (<div className="test-result-block existing-failure-block">
<h4>Existing failures - {existingFailures.length}</h4>
{existingFailures.map((t, i) => <TestCaseResultRow key={i} testCase={t} />)}
</div>);
}
if (fixed.length > 0) {
fixedBlock = [
<h4>Fixed</h4>,
fixed.map((t, i) => <TestCaseResultRow key={i} testCase={t} />),
];
fixedBlock = (<div className="test-result-block fixed-block">
<h4>Fixed</h4>
{fixed.map((t, i) => <TestCaseResultRow key={i} testCase={t} />)}
</div>);
}
if (skipped.length > 0) {
skippedBlock = [
<h4>Skipped - {skipped.length}</h4>,
skipped.map((t, i) => <TestCaseResultRow key={i} testCase={t} />),
];
skippedBlock = (<div className="test-result-block skipped-block">
<h4>Skipped - {skipped.length}</h4>
{skipped.map((t, i) => <TestCaseResultRow key={i} testCase={t} />)}
</div>);
}
}

7
blueocean-dashboard/src/main/less/testing.less
View File

@ -1,9 +1,12 @@
.test-results-container {
h4 {
margin: 1em 0 .4em 0;
.test-result-block {
margin: 1em 0 0 0;
&:first-child {
margin-top: 0;
}
h4 {
margin: 0 0 .4em 0;
}
}
.test-console {
padding: 1em;