Commit Graph

20 Commits

Author SHA1 Message Date
Carlos Sanchez ed1a330c47 Run shellcheck on build (#499)
And fix all the errors and warnings reported
2017-05-27 18:22:27 +02:00
Charles Duffy 3eec42cbad Full best-practices / shellcheck-compliance pass
- Use modern `$()` syntax vs backticks [see [SC2006](https://github.com/koalaman/shellcheck/wiki/SC2006)]
- Always check for, and bail on, failures of `cd`. [see [SC2164](https://github.com/koalaman/shellcheck/wiki/SC2164)]
- Avoid `for foo in $(...)`, per [DontReadLinesWithFor](http://mywiki.wooledge.org/DontReadLinesWithFor)
- Avoid parsing `ls` to find subdirectories when `for d in "$dir"/*/` does the job; see also [ParsingLs](http://mywiki.wooledge.org/ParsingLs)
- `\s` is not specified in POSIX ERE (thus, not guaranteed to be available in bash-native regexes unless local platform's C library's regex implementation extends standard); use `[[:space:]]` instead.
- Avoid unnecessary deviations from POSIX sh specification:
   - `echo -e` violates (not just extends) POSIX, doesn't work as expected in bash compiled with `--enable-xpg-echo-default`; [POSIX specification](http://pubs.opengroup.org/onlinepubs/009604599/utilities/echo.html) suggests `printf` as replacement (see APPLICATION USAGE section).
   - `function` keyword not specified in POSIX, provides no benefit over standard-compliant syntax
2016-09-26 17:03:10 +02:00
Carlos Sanchez 0ab4070108 Fix #319 Ignore plugins bundled under detached-plugins
They are not loaded by Jenkins in new installations
2016-08-05 10:44:58 +02:00
Carlos Sanchez 44deec3d33 Use spaces instead of tabs 2016-06-28 18:51:08 +02:00
Jim Zucker 4e24cacf92 #207, #219 - Filter out plugins already installed, updated with feedback 2016-06-28 18:50:07 +02:00
Chris Buckley 5373de8923 adding retry to plugins.sh for curl 2016-05-20 13:14:12 -04:00
Carlos Sanchez 75b17c4849 Issue #145 #146 Validate that plugins are zip files 2015-09-11 18:32:43 +02:00
Carlos Sanchez c1fdb58e08 Revert "Merge pull request #146 from ngiger/verify_downloads"
This reverts commit 4494a71285, reversing
changes made to 9395d3fdd7.
2015-09-11 17:48:18 +02:00
Niklaus Giger 995f681ced Verify that downloaded plugin is really a Zip archive 2015-09-08 12:01:45 +02:00
Carlos Sanchez d359b04067 Issue #106 Fix regresion by only checking JENKINS_UC_DOWNLOAD at runtime 2015-07-02 13:07:25 +02:00
Carlos Sanchez 004bc59f49 Show error message if curl fails 2015-07-02 13:07:14 +02:00
Luca Milanesio c15da9368f Allow usage of mirror Jenkins Update-Center for downloading plugins
Sometimes (like today ... and many other times unfortunately) the main
Jenkins update center is down and you cannot build a Jenkins Docker image.
It is much better than to include the full base URL as JENKINS_UC_DOWNLOAD
so that the ENV variable can be overridden to point to an up-and-running site.

Example:
ENV JENKINS_UC_DOWNLOAD http://mirrors.clinkerhq.com/jenkins
2015-06-16 10:50:11 +01:00
Jesse Glick 9c8ddc4e86 plugins.sh ought to fail if a plugin download failed. 2015-06-01 11:47:18 -04:00
Carlos Sanchez 69d55cd960 Rename plugins to jpi and pin them on initial installation 2015-05-15 10:54:07 +02:00
Carlos Sanchez c0475fd918 Issue #46 Last line of plugins.txt ignored if a new line is not present on that last line 2015-04-29 11:55:51 +02:00
Nikolay Yurin 390dc61ab2 Fix plugins downloading
- Add `-f` flag for curl to fail script on http error
- Add plugin version check, use `latest` if empty
- Show message on plugin download start and failure
- Silent downloading
2015-04-20 15:29:11 +03:00
Nicolas De loof d0eed1c432 Merge pull request #58 from pinguinkiste/improve-plugins-list
Ignore comments and empty lines in plugins file
2015-03-17 14:59:35 +01:00
Manuel Prinz dddb965c15 Ignore comments and empty lines in plugins file 2015-02-21 13:03:29 +01:00
Justin Clayton 8aec15c3cb fix description on location of plugins.sh
this is actually correct on the README.md, so alternately this line can just be removed entirely if the idea of merging changes to comments doesn't sit well with you. ;-)
2015-01-23 12:19:02 -08:00
Nicolas De Loof acb864940a fix #18
copy files from /sur/share/jenkins/ref to jenkins_home
so jenkins_home can be initialized with some reference
configuration/plugins but still can be customized and
be persisted on a volume

utility script to install plugins at startup based on
support-core plugin format
2014-11-28 08:34:14 +01:00