espeak: Adjust data permissions and minor cleanups

- Adjust data permissions in the post-install phase
 - Inject DATADIR via MAKE_FLAGS. We already do that for PREFIX
   (and this avoid possible headaches in `make patch; mkpatches; mkpatches -c'
   cycles)
 - Do not replace PREFIX in SUBST `datadir' class and only replace the hardcoded
   path of DATADIR in speech.h file
 - Delete the TODO, all entries addressed

espeak/Makefile

@@ -17,14 +17,18 @@ USE_TOOLS+=	gmake
 WRKSRC=		${WRKDIR}/${DISTNAME}/src
 
 MAKE_FLAGS+=	PREFIX=${PREFIX}
+MAKE_FLAGS+=	DATADIR=${PREFIX}/share/espeak-data
 
 SUBST_CLASSES+=		datadir
 SUBST_MESSAGE.datadir=	Replacing hardcoded DATADIR path
 SUBST_STAGE.datadir=	post-patch
-SUBST_VARS.datadir=	PREFIX
-SUBST_FILES.datadir=	Makefile speech.h
+SUBST_FILES.datadir=	speech.h
 SUBST_SED.datadir=	-e 's|/usr/share|${PREFIX}/share|'
 
+post-install:
+	cd ${WRKSRC} && ${FIND} ${DESTDIR}${PREFIX}/share -type f \
+	    -exec ${CHMOD} ${SHAREMODE} {} \;
+
 # Using v18 (v19 will get undefined reference to `Pa_StreamActive')
 .include "../../audio/portaudio/buildlink3.mk"
 .include "../../mk/pthread.buildlink3.mk"

espeak/TODO

@@ -1,3 +0,0 @@
-- Adjust permission of data files (probably they do not need execute
-  permissions!)
-- Function is tested only on 6.0-ish/i386 for now.