coccinelle: Reuse devel/menhir and also depends on pcre-ocaml

- Depends on devel/menhir, it seems that now it works
- Add a dependency on devel/pcre-ocaml, at least with current ocaml it seems
  that the test failed because they needed pcre-ocaml. Now the tests passes but
  we have a bit lower score than the one expected.
- Update TODO accordingly

coccinelle/Makefile

@@ -12,9 +12,9 @@ LICENSE=	gnu-gpl-v2
 
 BUILD_DEPENDS+=	ocaml-findlib-[0-9]*:../../devel/ocaml-findlib
 
-# the current version rejects this package's .mly file
-#DEPENDS+=	menhir>=20071212:../../devel/menhir
-CONFIGURE_ARGS+=	--without-menhir
+DEPENDS+=	menhir>=20071212:../../devel/menhir
+
+CONFIGURE_ARGS+=	--with-menhir
 CONFIGURE_ARGS+=	--disable-pyml
 
 MAKE_JOBS_SAFE=		no
@@ -45,6 +45,7 @@ TEST_TARGET=	test
 
 BUILDLINK_TRANSFORM+=	opt:-ldl:${BUILDLINK_LDADD.dl:M*}
 
+.include "../../devel/pcre-ocaml/buildlink3.mk"
 BUILDLINK_API_DEPENDS.ocaml+=	ocaml>=3.11
 .include "../../lang/ocaml/buildlink3.mk"
 .include "../../lang/camlp4/buildlink3.mk"

coccinelle/TODO

@@ -1,7 +1,8 @@
 Still not ready for using it to update devel/coccinelle. The following issues
 should be investigated further and if possible fixed:
 
- - pkgsrc `test' target no longer works (manually invoking that on ${WRKSRC}
-   does the trick, I guess that some naughty things happen when
-   compiling/linking test programs)
  - Update to coccinelle-1.0.6 breaks textproc/coccigrep
+
+   XXXleot: provide a simple command to test that.
+    
+    -- leot (2017/10/10)