Fix up some puppet-lint warnings, mostly unnecessary stringifying of variables

Gemfile

@@ -0,0 +1,10 @@
+source :gemcutter
+
+gem 'rake'
+gem 'rspec'
+gem 'cucumber'
+
+gem 'puppet'
+gem 'puppet-lint'
+gem 'puppetlabs_spec_helper'
+gem 'rspec-puppet'

Rakefile

@@ -0,0 +1,2 @@
+require 'rubygems'
+require 'puppetlabs_spec_helper/rake_tasks'

manifests/config.pp

@@ -18,9 +18,9 @@ class jira::config{
   require jira::params
 
   exec { 'mkdirp-homedir':
-    cwd     => "${jira::params::tmpdir}",
+    cwd     => $jira::params::tmpdir,
     command => "/bin/mkdir -p ${jira::params::homedir}",
-    creates => "${jira::params::homedir}"
+    creates => $jira::params::homedir
   }
 
   file { "${jira::params::webappdir}/bin/setenv.sh":
@@ -28,19 +28,20 @@ class jira::config{
     mode    => '0755',
     require => Class['jira::install'],
   }
-  
-  if "${jira::params::db}" == 'postgresql' {
+
+  if $jira::params::db == 'postgresql' {
     file { "${jira::params::homedir}/dbconfig.xml":
       content => template('jira/dbconfig.postgres.xml.erb'),
       mode    => '0600',
       require => [Class['jira::install'],Exec['mkdirp-homedir']],
     }
   }
-  if "${jira::params::db}" == 'mysql' {
+
+  if $jira::params::db == 'mysql' {
     file { "${jira::params::homedir}/dbconfig.xml":
       content => template('jira/dbconfig.mysql.xml.erb'),
       mode    => '0600',
       require => [Class['jira::install'],Exec['mkdirp-homedir']],
     }
   }
-}
+}

manifests/install.pp

@@ -18,16 +18,17 @@ class jira::install {
   require jira::params
 
   case $::osfamily {
-    'Darwin' : { # assuming you did download wget - ill maybe fix this and check for it
+    'Darwin' : {
+      # assuming you did download wget - ill maybe fix this and check for it
       exec { 'wget-jira-package':
-        cwd     => "${jira::params::tmpdir}",
+        cwd     => $jira::params::tmpdir,
         command => "${jira::params::cmdwget} --no-check-certificate ${jira::params::downloadURL}",
         creates => "${jira::params::tmpdir}/atlassian-${jira::params::product}-${jira::params::version}.${jira::params::format}",
       }
     }
     default : {
       exec { 'wget-jira-package':
-        cwd     => "${jira::params::tmpdir}",
+        cwd     => $jira::params::tmpdir,
         command => "${jira::params::cmdwget} --no-check-certificate ${jira::params::downloadURL}",
         creates => "${jira::params::tmpdir}/atlassian-${jira::params::product}-${jira::params::version}.${jira::params::format}",
       }
@@ -35,14 +36,14 @@ class jira::install {
   }
 
   exec { 'mkdirp-installdir':
-    cwd     => "${jira::params::tmpdir}",
+    cwd     => $jira::params::tmpdir,
     command => "/bin/mkdir -p ${jira::params::installdir}",
-    creates => "${jira::params::installdir}",
+    creates => $jira::params::installdir,
   }
   exec { 'unzip-jira-package':
-    cwd     => "${jira::params::installdir}",
+    cwd     => $jira::params::installdir,
     command => "/usr/bin/unzip -o -d ${jira::params::installdir} ${jira::params::tmpdir}/atlassian-${jira::params::product}-${jira::params::version}.${jira::params::format}",
-    creates => "${jira::params::webappdir}",
+    creates => $jira::params::webappdir,
     require => [Exec['wget-jira-package'],Exec['mkdirp-installdir']],
   }