rust
/
cargo
mirror of https://github.com/rust-lang/cargo
0
0
Fork 0
Code Issues Releases Wiki Activity

Explain why we keep -Zfeatures=compare

This commit is contained in:
Weihang Lo 2022-09-30 22:34:42 +01:00
parent da6a8f01fe
commit 3a6bea6b26
No known key found for this signature in database
GPG Key ID: D7DBF189825E82E7
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/cargo/core/features.rs
View File

@ -931,10 +931,13 @@ impl CliUnstable {
"host-config" => self.host_config = parse_empty(k, v)?,
"target-applies-to-host" => self.target_applies_to_host = parse_empty(k, v)?,
"features" => {
// For now this is still allowed (there are still some
// unstable options like "compare"). This should be removed at
// some point, and migrate to a new -Z flag for any future
// things.
// `-Z features` has been stabilized since 1.51,
// but `-Z features=compare` is still allowed for convenience
// to validate that the feature resolver resolves features
// in the same way as the dependency resolver,
// until we feel confident to remove entirely.
//
// See rust-lang/cargo#11168
let feats = parse_features(v);
let stab_is_not_empty = feats.iter().any(|feat| {
matches!(