rust/rustls
rust
/
rustls
mirror of https://github.com/ctz/rustls
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove checks on certtypes in CertificateRequest

This commit is contained in:
Joseph Birr-Pixton 2020-05-15 20:32:36 +01:00
parent 616392f4d8
commit 63584de444
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
rustls/src/client/tls12.rs
View File

@ -6,7 +6,6 @@ use crate::msgs::handshake::{HandshakePayload, HandshakeMessagePayload};
use crate::msgs::handshake::DecomposedSignatureScheme;
use crate::msgs::handshake::ServerKeyExchangePayload;
use crate::msgs::handshake::DigitallySignedStruct;
use crate::msgs::enums::ClientCertificateType;
use crate::msgs::codec::Codec;
use crate::msgs::persist;
use crate::msgs::ccs::ChangeCipherSpecPayload;
@ -16,7 +15,7 @@ use crate::suites;
use crate::verify;
use crate::ticketer;
#[cfg(feature = "logging")]
use crate::log::{debug, trace, warn};
use crate::log::{debug, trace};
use crate::error::TLSError;
use crate::handshake::{check_message, check_handshake_message};
@ -326,13 +325,9 @@ impl hs::State for ExpectCertificateRequest {
// The RFC jovially describes the design here as 'somewhat complicated'
// and 'somewhat underspecified'. So thanks for that.
// We only support RSA signing at the moment. If you don't support that,
// we're not doing client auth.
if !certreq.certtypes.contains(&ClientCertificateType::RSASign) {
warn!("Server asked for client auth but without RSASign");
return Ok(self.into_expect_server_done(client_auth));
}
//
// We ignore certreq.certtypes as a result, since the information it contains
// is entirely duplicated in certreq.sigschemes.
let canames = certreq.canames
.iter()