rust
/
smol
mirror of https://github.com/stjepang/smol
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #143 from stjepang/unlock-before-wake 

Drop locks before waking tasks
This commit is contained in:
Stjepan Glavina 2020-05-28 06:32:09 -07:00 committed by GitHub
parent ee25d12cac a37c1ee8ea
commit b1b5986ef7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/reactor.rs
View File

@ -224,6 +224,9 @@ impl Reactor {
Some(Duration::from_secs(0))
};
// Drop the lock before waking.
drop(timers);
// Wake up tasks waiting on timers.
for (_, waker) in ready {
waker.wake();
@ -273,6 +276,7 @@ impl ReactorLock<'_> {
Ok(_) => {
// Iterate over sources in the event list.
let sources = self.reactor.sources.lock();
let mut ready = Vec::new();
for ev in self.events.iter() {
// Check if there is a source in the table with this key.
@ -281,20 +285,24 @@ impl ReactorLock<'_> {
// Wake readers if a readability event was emitted.
if ev.readable {
for w in wakers.readers.drain(..) {
w.wake();
}
ready.append(&mut wakers.readers);
}
// Wake writers if a writability event was emitted.
if ev.writable {
for w in wakers.writers.drain(..) {
w.wake();
}
ready.append(&mut wakers.writers);
}
}
}
// Drop the lock before waking.
drop(sources);
// Wake up tasks waiting on I/O.
for waker in ready {
waker.wake();
}
return Ok(());
}