Commit Graph

304 Commits

Author SHA1 Message Date
Ben Osheroff d8b8f83690 1.8.7 has no version.h 2015-06-16 20:55:55 -07:00
R. Tyler Croy 7f63e3c0d3 Merge pull request #109 from zendesk/better_postloop_cleanup
Better postloop cleanup
2015-06-15 06:55:35 -07:00
R. Tyler Croy c272bff063 Merge pull request #108 from zendesk/metadata
Add the ability to request cluster / topic metadata from the brokers
2015-06-15 06:54:31 -07:00
R. Tyler Croy 6fb9e064b4
Up the minor version for a manual deployment 2015-06-15 06:19:30 -07:00
R. Tyler Croy 4e1d359107
Remove auto-deploy until Java- specific versions can be published too 2015-06-15 06:18:02 -07:00
R. Tyler Croy 755d578a75 Merge pull request #111 from zendesk/rdkafka_0_8_6
upgrade to librdkafka 0.8.6
2015-06-15 06:00:49 -07:00
Ben Osheroff 74cba3c513 upgrade to librdkafka 0.8.6
R. Tyler's patches are included in librdkafka 0.8.6
2015-06-14 19:33:41 -07:00
Ben Osheroff 5c898144f2 cleanup warnings
- fix partition selection function
- get ruby >= 2 calling the correct no-gvl function
2015-06-13 19:47:07 -07:00
Ben Osheroff 17e5c5b31d ensure we call consumer_consume_loop_stop at the end of the loop
we need rb_ensure so that if the loop terminates in a "break" statement
we'll still call rd_kafka_consume_stop
2015-06-13 19:06:45 -07:00
Ben Osheroff 942fd87728 call rd_kafka_message_destroy right before rb_yield()
if rb_yield() ends in a "break" statement, it never returns control back
to the caller; thus we leak the message.
2015-06-13 19:05:25 -07:00
Ben Osheroff 3f0da9e0cd stop using named params in Partition#consumer 2015-06-13 14:12:57 -07:00
Ben Osheroff 0bc9e9d9ee don't destory metadata unless it's allocated 2015-06-12 18:11:34 -07:00
Ben Osheroff 83ea24a20e Merge remote-tracking branch 'upstream/master' into metadata 2015-06-11 16:22:32 -07:00
Ben Osheroff f3b6df06d3 update README.md with metadata request 2015-06-11 16:21:08 -07:00
Ben Osheroff c2540a8410 update api to have #topic(topic) as well as #topics
also add Partition#consumer to instantiate a coonsumer object on the
particular partition
2015-06-11 15:29:02 -07:00
Ben Osheroff 7edd297071 add Broker#to_s 2015-06-11 15:25:01 -07:00
R. Tyler Croy 2187463a5d Merge pull request #107 from lookout/fix-integ
fix integration tests
2015-06-01 11:50:41 -07:00
jway 2aecf369e6 fix integration tests 2015-06-01 09:42:37 -07:00
Ben Osheroff e7e1a2a7ac raise default timeout and make it configurable 2015-05-19 13:51:59 -07:00
Ben Osheroff 314ea3d8f8 fetching an empty topic doesn't work 2015-05-19 13:44:57 -07:00
Ben Osheroff 326b428b34 slap a friendlier face on the returned metadata interface 2015-05-19 13:34:39 -07:00
Ben Osheroff 7779654f36 Merge remote-tracking branch 'upstream/master' into metadata 2015-05-19 11:38:08 -07:00
Ben Osheroff 5942e1810b fix bug, constantize TIMEOUT_MS, add README.md info 2015-05-19 11:33:13 -07:00
Ben Osheroff e38b626b71 Add metadata API to Hermann::Discovery module 2015-05-19 11:13:27 -07:00
R. Tyler Croy 8c614437bf Merge pull request #106 from pocman/patch-2
Update Hacking.md with mri instructions
2015-05-19 07:54:07 -07:00
R. Tyler Croy a833a7e366 Merge pull request #105 from pocman/patch-4
Fix TypeError conversion of Array into String
2015-05-19 07:52:00 -07:00
Thomas 7100c84059 Fix TypeError conversion of Array into String
When running rake spec:integration with /fixtures/integration.yml

Hermann::Lib::Producer #connect should connect
     Failure/Error: subject(:producer) { Hermann::Lib::Producer.new(brokers) }
     TypeError: no implicit conversion of Array into String
     # ./spec/hermann_lib/producer_spec.rb:10:in `initialize'
2015-05-19 11:00:25 +02:00
Thomas 05814e4f57 Update Hacking.md with mri instructions 2015-05-19 10:33:00 +02:00
R. Tyler Croy 5142115847 Merge pull request #104 from pocman/patch-1
Add Zk discovery availablility with MRI to readme
2015-05-18 08:15:26 -07:00
Thomas 6838ec2cdf Add Zk discovery availablility with MRI to readme 2015-05-18 12:58:22 +02:00
R. Tyler Croy 6275021f11 Merge pull request #103 from lookout/retro-ruby
I've had requests to run CI against retro versions of Ruby
2015-05-07 16:39:25 -07:00
R. Tyler Croy 7b4ea2f2df Properly handle pulling in fixtures code across Ruby versions 2015-05-07 13:56:36 -07:00
R. Tyler Croy 3fda5ec3f3 Rework the dependencies and some of the code to support retro rubies better 2015-05-07 13:18:41 -07:00
R. Tyler Croy 069150cd1f I've had requests to run CI against retro versions of Ruby 2015-05-07 11:46:16 -07:00
R. Tyler Croy a362ce153e Merge pull request #98 from zendesk/fix_1.9.3
1.9.3 fixes
2015-04-30 08:11:38 -07:00
Ben Osheroff efd1a80a37 1.9.3 fixes
1.9.3 seems like it should actually still be using the
rb_thread_blocking_region() call, as ...call_without_gvl() isn't defined
in any header (although it is available).

Consuming that implicit declaration was causing crashes.
2015-04-30 07:52:01 -07:00
R. Tyler Croy 4c451b4344 Merge pull request #97 from zendesk/fix_use_after_free
Fix use-after-free bug
2015-04-29 15:54:38 -07:00
Ben Osheroff 30669be4d5 Fix use-after-free bug
it's not safe to simply pluck strings off the heap unless we were also
going to maintain a reference to them.  sidestep this problem by
strdup'ing the topic and brokers strings
2015-04-29 14:33:58 -07:00
R. Tyler Croy a3d8998a6f Image and link, DUH 2015-04-28 15:53:14 -07:00
R. Tyler Croy 76e8841998 Modify the build badge to point to the right travis project 2015-04-28 15:52:12 -07:00
R. Tyler Croy 4aef448dbc Merge pull request #95 from zendesk/mri_offsets
mri, initial offsets
2015-04-28 15:41:33 -07:00
Ben Osheroff 3fbe6969fb update tests with InvalidOffsetError 2015-04-28 15:14:14 -07:00
Ben Osheroff 8832ad28fd update rdoc section with :offset documentation 2015-04-28 11:52:16 -07:00
Ben Osheroff 8e89b75801 add a type to the invalid offset error 2015-04-28 11:50:28 -07:00
R. Tyler Croy e872906465 Merge pull request #92 from zendesk/fix_gvl
use rb_thread_call_without_gvl
2015-04-28 11:39:31 -07:00
Ben Osheroff 4f4e3f9b55 add some documentation to the new MRI consumer functions 2015-04-28 11:07:33 -07:00
Ben Osheroff 8857531cb7 add a constant for the time we ignore the gvl's interrupt requests 2015-04-28 11:06:34 -07:00
Ben Osheroff 752123b83e allow choosing of an inital offset in the MRI consumer 2015-04-28 10:17:09 -07:00
Ben Osheroff 21190d7acd randomize integration test topic 2015-04-28 10:09:30 -07:00
Ben Osheroff 8b7a31a232 add mri script 2015-04-28 10:09:02 -07:00