Commit Graph

3261 Commits

Author SHA1 Message Date
R. Tyler Croy f808d03a34
Since version 1.6, the GitHub Organization Folder has been an obsolete tombstone
No need for installations to keep installing it anew, the required functionality
has been incorporated into the github-branch-source plugin.

See: https://github.com/jenkinsci/github-organization-folder-plugin
2017-07-19 20:32:02 -07:00
Vivek Pandey 820c57245b Bump cloudbees-folder-plugin to 6.1.0 to fix classic dashboard error (#1263)
branch-api-plugin depends on cloudbees-folder-plugin 6.1.0.
2017-07-19 17:33:53 -07:00
Nicolae Pascu b8c93fb1a8 Bug/jenkins 40163 baseline shift in breadcrumbs (#1235)
* fix baseline shift in breadcrumbs

* publish jdl and core-js beta versions

* make the run number match the baseline of the breadcrumb

* publish beta versions of core-js and jdl

* make title underlined on hover, this will keep the behaviour consistent with other screens

* release new ver of core-js

* release new version of core-js that has a jdl that is non-beta
2017-07-19 21:14:14 +03:00
Nicolae Pascu 726e285421 JENKINS-45016 Branch filter clear behaviour (#1227)
* set the original value back if blured with an empty value, force the branch filter to lose focus after change

the setTimeout hack is used to get the functions out of the call stack and only run it when the stack is empty

* fix lint error

* use state to change the value of the branch filter input instead of manipulating the dom directly

* fix lint error
2017-07-19 00:33:12 +03:00
Vivek Pandey b12cad8ac5 Bitbucket Cloud and Server (#1195)
* JENKINS-44666# Pipeline creation for bitbucket server

* Moved GitContent over to scm package

This is the right package for it to be in and there are enouhg tests for
it in github and bitbucket modules.

* test refactoring to run wiremock with differetn target api servers

* Fixed index.jelly description

* AbstractBitbucketScm to serve as super class for server and cloud impl

* Bitbucket cloud models and refactoring

* Bitbucket cloud API

Includes related tests.

* Set bb server url only if the target is bb server and not cloud

* Bug fixes

* Wiremock related adjustment to api factory selection during test

* Test improvements for bb cloud

* Set jenkins root url from request if not already set

This is to keep bitbucket build notifications to work out of the box.

* bitbucket api endpoint to be served from https://bitbucket.org/api

This is to be in line with bitbucket-branch-source that uses this url
instead of https://api.bitbucket.org. This is so that we can use
credentials across to bitbucket-branch-source.

* bitbucket module parent version bump

* Doc improvements and cleanup

* Fixed accidentally moved github wiremock recordings

* Now really fixing it, missed to add these wiremock files

* Upgraded to improved branch source api

* Bitbucket server endpoint and endpoint related refactoring

* i18n test fix

* Corrected error text

* Beginning work on bitbucket front end

* Fixed import

* By default set 'All Branch' trait

* Working bitbucket cloud pipeline creation

* Removed accidentally checked in files

* BitBucket server pipeline creation

* List user org together with teams in bitbucket cloud org list

* Use correct BB server URL API from BB branch source API

* bumped up versions

* Replace BitBucket by Bitbucket

* 'newInstance' renamed to 'create' for consistency

* i18n fixes and improvements

* Reverted code to use server name

We display URL of server below selected server name from drop down. If
name is null then url is displayed instead.

* Updated bitbucket icon

* id added as property to ScmServerEndpoint and related refactoring

* Bitbucket server version validation API

* Bitbucket server version validation in creation flow

* Fixed lint issue

* delint

* Content creation in empty repo and i18n fix

* Fixed bug to correctly determine user org

* Fixed credential/choose server state and some cleanup

* Plain getUser() require higher privilage and we don't need it so removed

* Fixed completions state properly and other fixes mentioned in Cliff
feedback

* Upgraded branch source to released version

* Introduced feature flag to enable bitbucket pipeline creation

* We need to fetch user with credentials, reverted this code for correct
behavior

* Updaed pom version

* Invalid url error message fix
2017-07-18 12:50:57 -04:00
Vivek Pandey d1ee67be89 [maven-release-plugin] prepare for next development iteration 2017-07-18 12:41:10 +00:00
Vivek Pandey b6c3da9d74 [maven-release-plugin] prepare release blueocean-parent-1.2.0-beta-2 2017-07-18 12:41:06 +00:00
Tom Fennelly 1d9d218582 pubsub-1.12 (#1256)
* pubsub snapshot version

* pubsub 1.12
2017-07-18 10:47:01 +01:00
Ivan Meredith 5af7343343 JENKINS-43906: Git creation ath tests (#1217)
* Test

* Update jenkinsfile'

* typo

* typo

* Increase timeout

* more timeouts

* Refresh page

* wayward backtick

One day we will crash into mars because of a typo

* adding in a reload for activity screen

* relaxing timeouts

* Use sse for refresh

* debugging

* reorder tests

* hail mary

* More debugging

* Ignore test
2017-07-17 16:22:42 +12:00
Ivan Meredith 40ed3e647e Take ScreenShots on any exception (#1255) 2017-07-17 14:38:21 +12:00
Ivan Meredith b051c420f3 Add retry support for tests via @Retry(n) (#1251)
* Add retry support for tests via @Retry(n)

* Fix failure

* Clear failures

* fix compilation issue
2017-07-17 11:48:41 +12:00
Michael Neale e7c15a148c relax more timings (#1250) 2017-07-13 15:48:05 +10:00
James William Dumay 5f5588b72f Disembiguate generic "Not Found" error reported in JENKINS-45253 (#1247)
* Disembiguate generic "Not Found" error reported in JENKINS-45253

* Improve message
2017-07-13 14:10:10 +10:00
James Dumay 97e6f90ec9 Revert "Update pom.xml (#1248)"
This reverts commit 5b1ead5a58.
2017-07-13 11:04:27 +10:00
James William Dumay 5b1ead5a58 Update pom.xml (#1248) 2017-07-13 11:03:22 +10:00
Ivan Meredith f4237420c6 Increase timeout on ATH (#1243)
* Increase timeout on ATH

* moar timeout
2017-07-13 09:01:04 +10:00
James William Dumay a98c178c4d Impersonate SYSTEM for addEndpoint (#1245) 2017-07-13 06:54:26 +10:00
Michael Neale 484ee06452 Use api.github.com if is already exists when testing GHE (#1244)
Previous builds failing as github branch source unifies github enterprise and github cloud
2017-07-12 14:26:29 +10:00
Michael Neale 7f5b115abe switch to addEndpoint (#1242) 2017-07-12 07:35:19 +10:00
Nicolae Pascu 38b5721d9c Bug/jenkins 44718 step description does not show ellipsis when truncated (#1236)
* fix step description not showing ellipsis when truncated, add title to step description

* publish beta versions of jdl and core-js

* publish jdl and core-js
2017-07-11 23:30:56 +03:00
Nicolae Pascu 4da3f23c48 update default page title (#1238) 2017-07-11 18:02:51 +03:00
Nicolae Pascu 0d19bdfda8 make header link a real anchor (#1240) 2017-07-11 18:02:01 +03:00
James Dumay c96b9f263b Revert "Move to addEndpoint() to retain binary compatibility (#1241)"
This reverts commit 974856d4ef.
2017-07-11 15:46:10 +10:00
James William Dumay 974856d4ef Move to addEndpoint() to retain binary compatibility (#1241) 2017-07-11 14:35:42 +10:00
Ivan Meredith 60d517c738 JENKINS-44698: test new branch creation (#1233) 2017-07-11 12:46:35 +12:00
Josh McDonald 197893bdbb Update run details artefacts view to new table design (#1232)
* feature/JENKINS-41833-artefacts-table * Convert artefacts table to new table design

* feature/JENKINS-41833-artefacts-table * Fix download button style

* feature/JENKINS-41833-artefacts-table * Lint and test fixes

* feature/JENKINS-41833-artefacts-table * Some ATH updates to run on dogfood

* feature/JENKINS-41833-artefacts-table Delete unused old cell link component

* feature/JENKINS-41833-artefacts-table * Rename RunDetailsRow to ActivityDetailsRow as per Cliff's suggestion

* feature/JENKINS-41833-artefacts-table * Fix a typo Keith noticed, and clean up some proptypes

* feature/JENKINS-41833-artefacts-table * Fix proptypes issue
2017-07-11 09:32:17 +10:00
Devin Breen 9417b1f86e Simple grammar correction (#1239) 2017-07-11 07:59:04 +10:00
Ivan Meredith 6dcd16c86b ATH 2.60.1 (#1234) 2017-07-10 14:45:01 +12:00
Josh McDonald f1e8a72285 feature/JENKINS-41833-run-changes (#1231)
* Update RunDetailsChanges
 * Style changes to support multi-line table cells
 * Updated unit tests
 * Update README to reflect update to Jest (stolen from core-js README)
2017-07-06 21:55:40 +10:00
Jesse Glick 0a10c232d8 Use GraphListener and FlowExecutionListener to receive events. (#1228) 2017-07-06 19:29:01 +10:00
Thorsten Scherler 8dd48ead72 [JENKINS-45292] Dropdown should allow custom footer (#1222)
* [JENKINS-45292-dropdown-footer] Add ability to add custom footer to dropdown menu

* [JENKINS-45292-dropdown-footer] version dance

* [JENKINS-45292-dropdown-footer] prepare next version
2017-07-05 16:13:31 +02:00
James William Dumay 4fad22560f fix pom warnings (#1225) 2017-07-05 17:00:46 +10:00
Michael Neale 61dd50d8e3 Replay and retry test fix with wait time
There appears to be a race/eventual consistency problem without a wait in place.
2017-07-05 12:58:33 +10:00
James William Dumay 4d1dedce24 CoreJS dance (#1223) 2017-07-05 11:26:44 +10:00
James William Dumay 0c8023754e Add ability to post to the analytics track endpoint (#1218)
* Add ability to post to the analytics track endpoint

* Oh eslint gods you are cruel and greedy

* Fix index.js
2017-07-05 10:12:03 +10:00
Josh McDonald 6d3c5c5dad Update Pull Requests view to new tables (#1220)
* feature/JENKINS-41833-pr-table-update * Update to PR tab for new tables almost complete, need to pull from master

* feature/JENKINS-41833-pr-table-update * Cleanups, squash last few TODOs, and appease the lint gods

* feature/JENKINS-41833-pr-table-update * Fix some stupid errors

* feature/JENKINS-41833-pr-table-update * Update tests

* feature/JENKINS-41833-pr-table-update * Tweak author col
2017-07-05 09:01:38 +10:00
Cliff Meyers cbbe5ed026 Improvement/jenkins 40855 GitHub enterprise avatar placeholder (#1216)
* enhance the github API proxies to support "github" and new "github-enterprise" endpoints; omit explicit API URL from creation call

* add "GitHub Enterprise" as a creation option; adjust layout of buttons to wrap correctly

* add semantic classes to github creation elements so tests don't break after label changes

* ensure the credential ID for github enterprise is "github-enterprise" rather than github (to avoid duplicate ID's)

* add specific logic to handle the case where the user-supplied URL is malformed

* ensure the credential ID for github enterprise is "github-enterprise" rather than github (to avoid duplicate ID's)

* add specific logic to handle the case where the user-supplied URL is malformed

* also check for UnknownHostException

* add support for "GitHub Enterprise URL" field and handle relevant errors; still needs some UI layout refinement

* also check for UnknownHostException

* pass through empty string so it results in invalid URL error from backend (rather than allowing it to default to public github API URL)

* refine layout

* ensure "apiUrl" parameter is not passed during public GitHub creation flow

* first pass at reworking GitHubEnterpriseScm to support multiple credentials stored in "blueocean-github-enterprise-domain" - need to investigate numerous test regressions

* push most logic for custom apiUrl back into GithubScm but make it required in GithubEnterpriseScm

* better test coverage for Github Enterprise token validation

* clean imports

* add functional test for token validaton error; add testing utility to allow for user / domain credentials to be deleted

* rework GithubEnterpriseScm so that apiUrl is a required parameter and drives 404 vs 200 behavior on GET requests

* fix findbugs NPE warning

* suppress type warning

* simplify apiUrl logic

* fix findbugs NPE violation

* hash the apiUrl portion of the credentialId using SHA-256 hex

* GitHub Enterprise credentials should start with "github-enterprise"  (scm.ID) rather than the credential domain's name

* just look up the credential explicitly via credentialId; remove the new CredentialUtils.findCredentials method added in this PR since it's no longer necessary

* remove wildcard imports

* add @Nonnull return type to createCredentialId()

* make credential description overridable so that "GitHub Enterprise Access Token" is used for GHE

* return 200 with null credentialId rather than 404

* work-in-progress for looking up existing GHE credential

* add a utility class / function for transforming REST API URL's to include the "apiUrl" param

* cleaner init

* update Github*Api's to append apiUrl in appropriate places

* isolate GHE custom behavior to a FlowManager subclass

* make the "existing token will be used" scenario nicer

* ensure the apiUrl is being passed to the final creation call in GHE scenario

* make the final creation endpoint handle URL's with trailing slashes gracefully

* Enumerate Github Servers (#1190)

* wip of new "choose server" step and "add server" dialog

* add getApiUrl() so it can be easily overriden

* allow the location of credentials step and organizations step to be more easily controlled

* API for github enterprise "servers" backend

* report the error message back to client

* finish up "add server" dialog; add some utilities for dealing with backend error messages and rendering them

* wire up the "next" button in "Choose Server" step to proceed to access token or organizations step

* revert changes related to first draft of UI for GHE credential / apiUrl management

* revert changes related to first draft of UI for GHE credential / apiUrl management

* fix bug where generic error message was showing inappropriately in "invalid URL" case

* revert changes related to first draft of UI for GHE credential / apiUrl management

* fix broken unit test for Enum

* Add a proxy for Github.com to simulate Github Enterprise

* add back the "apiUrl" parameter that was mistakening removed

* improve the error message when unexpected exception is thrown connecting to GHE server; fix broken test

* Find/replace all urls

* Find/replace all urls v2

* use password field for github token

* fix a bug where step indicators were not styled appropriately due status classes not forced to lowercase (with unit test)

* improve docs for Enum and add some test coverage

* make class names in GHE "Choose Server" step more specific

* add some Selenium-based utilities for conditions and text field manipulation

* temp workaround code to allow servers with the "same" API URL to be created by appending random query string param

* first draft of reusable utility for working with GitHub repos from automated tests; needs a bunch of refinement to more flexible

* use new "clearText" utility method

* basic ATH coverage for GitHub Enterprise: create a new server, finish creation, open in editor

* ensure repo name w/ random suffix is used

* write a utility to extract protocol / host from a URL

* ensure the link to create the GitHub personal access token points to the correct hostname (either github.com or GHE)

* me fail english? that's unpossible!

* [JENKINS-45238] first pass at backend changes to null out GitHub enterprise avatarUrl

* wip to satisfy test coverage

* fix silly iterator error

* assert that "avatar" property is nulled out for GHE

* use a placeholder image for GHE orgs

* comments

* simplify the logic that drives the avatar URL

* remove unused imports
2017-07-04 09:32:30 -04:00
Josh McDonald dc2b8b5177 Tweak commit lozenge (#1221)
* bug/JENKINS-44107-moar-commit-lozenge * Round off the commit lozenge a bit less, since it's only 18px high

* Squircle mode

* bug/JENKINS-44107-moar-commit-lozenge * Fix issues with margin and flex params
2017-07-04 20:10:36 +10:00
James William Dumay 6306efe7a7 Dependency updates (#1219) 2017-07-04 16:00:31 +10:00
James William Dumay 6e2b4a6494 Add browser and operating system stats to all event properties (#1210) 2017-07-04 07:17:11 +10:00
Keith Zantow b16ea72cc4 Merge JDL to blueocean-plugin 2017-07-03 14:48:59 -04:00
kzantow da4bfedc05 Merge remote-tracking branch 'jdl/master' 2017-07-03 12:07:05 -04:00
kzantow d34f1cef41 Merge remote-tracking branch 'primary/master' 2017-07-03 11:47:05 -04:00
Cliff Meyers f62e0c02fe bug / jenkins 44522 top nav pipelines link highlight (#1157)
* experiment with drawing active state around top-level Pipelines link

* fix test that broke after extension point changes

* fix entertaining typo

* remove bogus "AdminLink" extension point now that PipelinesTopLink will trigger equivalent CSS loading

* rename for clarity
2017-07-03 11:15:00 -04:00
Cliff Meyers bc27270b69 Story/jenkins 40855 creation GitHub enterprise (#1189)
* enhance the github API proxies to support "github" and new "github-enterprise" endpoints; omit explicit API URL from creation call

* add "GitHub Enterprise" as a creation option; adjust layout of buttons to wrap correctly

* add semantic classes to github creation elements so tests don't break after label changes

* ensure the credential ID for github enterprise is "github-enterprise" rather than github (to avoid duplicate ID's)

* add specific logic to handle the case where the user-supplied URL is malformed

* ensure the credential ID for github enterprise is "github-enterprise" rather than github (to avoid duplicate ID's)

* add specific logic to handle the case where the user-supplied URL is malformed

* also check for UnknownHostException

* add support for "GitHub Enterprise URL" field and handle relevant errors; still needs some UI layout refinement

* also check for UnknownHostException

* pass through empty string so it results in invalid URL error from backend (rather than allowing it to default to public github API URL)

* refine layout

* ensure "apiUrl" parameter is not passed during public GitHub creation flow

* first pass at reworking GitHubEnterpriseScm to support multiple credentials stored in "blueocean-github-enterprise-domain" - need to investigate numerous test regressions

* push most logic for custom apiUrl back into GithubScm but make it required in GithubEnterpriseScm

* better test coverage for Github Enterprise token validation

* clean imports

* add functional test for token validaton error; add testing utility to allow for user / domain credentials to be deleted

* rework GithubEnterpriseScm so that apiUrl is a required parameter and drives 404 vs 200 behavior on GET requests

* fix findbugs NPE warning

* suppress type warning

* simplify apiUrl logic

* fix findbugs NPE violation

* hash the apiUrl portion of the credentialId using SHA-256 hex

* GitHub Enterprise credentials should start with "github-enterprise"  (scm.ID) rather than the credential domain's name

* just look up the credential explicitly via credentialId; remove the new CredentialUtils.findCredentials method added in this PR since it's no longer necessary

* remove wildcard imports

* add @Nonnull return type to createCredentialId()

* make credential description overridable so that "GitHub Enterprise Access Token" is used for GHE

* return 200 with null credentialId rather than 404

* work-in-progress for looking up existing GHE credential

* add a utility class / function for transforming REST API URL's to include the "apiUrl" param

* cleaner init

* update Github*Api's to append apiUrl in appropriate places

* isolate GHE custom behavior to a FlowManager subclass

* make the "existing token will be used" scenario nicer

* ensure the apiUrl is being passed to the final creation call in GHE scenario

* make the final creation endpoint handle URL's with trailing slashes gracefully

* Enumerate Github Servers (#1190)

* wip of new "choose server" step and "add server" dialog

* add getApiUrl() so it can be easily overriden

* allow the location of credentials step and organizations step to be more easily controlled

* API for github enterprise "servers" backend

* report the error message back to client

* finish up "add server" dialog; add some utilities for dealing with backend error messages and rendering them

* wire up the "next" button in "Choose Server" step to proceed to access token or organizations step

* revert changes related to first draft of UI for GHE credential / apiUrl management

* revert changes related to first draft of UI for GHE credential / apiUrl management

* fix bug where generic error message was showing inappropriately in "invalid URL" case

* revert changes related to first draft of UI for GHE credential / apiUrl management

* fix broken unit test for Enum

* Add a proxy for Github.com to simulate Github Enterprise

* add back the "apiUrl" parameter that was mistakening removed

* improve the error message when unexpected exception is thrown connecting to GHE server; fix broken test

* Find/replace all urls

* Find/replace all urls v2

* use password field for github token

* fix a bug where step indicators were not styled appropriately due status classes not forced to lowercase (with unit test)

* improve docs for Enum and add some test coverage

* make class names in GHE "Choose Server" step more specific

* add some Selenium-based utilities for conditions and text field manipulation

* temp workaround code to allow servers with the "same" API URL to be created by appending random query string param

* first draft of reusable utility for working with GitHub repos from automated tests; needs a bunch of refinement to more flexible

* use new "clearText" utility method

* basic ATH coverage for GitHub Enterprise: create a new server, finish creation, open in editor

* ensure repo name w/ random suffix is used

* write a utility to extract protocol / host from a URL

* ensure the link to create the GitHub personal access token points to the correct hostname (either github.com or GHE)

* me fail english? that's unpossible!
2017-07-03 10:55:46 -04:00
James William Dumay 3d82f94257 Fix issue where nagative hits are put in the cache as null and it NPEs (#1181) 2017-07-03 21:47:31 +10:00
Andrei Ovsiankin 66105ac9a7 Translation files for Russian (#1139)
* Translation files

* Terms changed

* Untranslated keys removed

* New translations Messages.properties (Russian)

* New translations Messages.properties (Russian)

* New translations Messages.properties (Russian)

* New translations Messages.properties (Russian)

* New translations Messages.properties (Russian)
2017-07-03 16:07:14 +10:00
James William Dumay 80c553080d JENKINS-45089 ensure we use the limit and abuse rate handlers consistently (#1214) 2017-07-03 12:40:43 +10:00
Thorsten Scherler 679c505edb [JENKINS-45217_title_in_dropdown] Version dance (#1213) 2017-07-03 11:57:25 +10:00
Thorsten Scherler 4142b184d7 [FIX-JENKINS-45217] title_in_dropdown: allow custom title (#179)
* [JENKINS-45217_title_in_dropdown] allow custom title

* [JENKINS-45217_title_in_dropdown] bump version

* [JENKINS-45217_title_in_dropdown] Add test to cover title behaviour in dropDown

* [JENKINS-45217_title_in_dropdown] extract variable
2017-06-30 11:41:11 +02:00