rtyler
/
brokenco.de
1
0
Fork 0
Code Pull Requests Releases Activity

Update my Gerrit guide with a note about replication 

I've learned quite a bit since then :)
This commit is contained in:
R. Tyler Croy 2011-07-23 14:32:53 -07:00
parent fe1c26518c
commit ab3cfc0e98
1 changed files with 159 additions and 151 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
_posts/2009-12-07-code-review-with-gerrit-a-mostly-visual-guide.markdown
View File

@ -7,6 +7,14 @@ tags:
nodeid: 241
created: 1260254725
---
**Update:** Some of this information is out of date. Instead of pushing to the
`gerrit` master branch I recommend setting up
"[replication](http://gerrit.googlecode.com/svn/documentation/2.0/config-replication.html)" and using the
"Submit" button inside of the "Review" page.
----
A while ago, when <a id="aptureLink_DCQGFvVLOq" href="http://twitter.com/pjthiel">Paul</a>, <a id="aptureLink_BbwdfFjMPz" href="http://twitter.com/jasonrubenstein">Jason</a> and I worked together, I became a big fan of code reviews before merging code. It was no surprise really, we were the first to adopt <a id="aptureLink_ySC1aL45rF" href="http://en.wikipedia.org/wiki/Git%20%28software%29">Git</a> at the company and our workflow was quite ad-hoc, the need to federate knowledge within the group meant code reviews were a pretty big deal. At the time, we mostly did code reviews in person by way of "hey, what's this you're doing here?" or by literally sending patch emails with <a id="aptureLink_NlYWR6qaQY" href="http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html">git-format-patch(1)</a> to the team mailing list so all could participate in the discussion about what merits "good code" exhibited versus "less good code." Now that I've left that company and joined another one, I've found myself in another small-team situation, where my teammates place high value on code review. Fortunately this time around better tools exist, namely: <a id="aptureLink_suzQh0OgeJ" href="http://code.google.com/p/gerrit/">Gerrit</a>.
The history behind Gerrit I'm a bit hazy on, what I do know is that it's primary developer Shawn Pearce (<a id="aptureLink_ZO1gp7ghRJ" href="http://www.linkedin.com/pub/shawn-pearce/0/a93/61">spearce</a>) is one of the Git "inner circle" who contributes heavily to Git itself as well as <a id="aptureLink_ORrreTOiql" href="http://www.jgit.org/">JGit</a>, a Git implementation in Java which sits underneath Gerrit's internals. What makes Gerrit unique in the land of code review systems is how tightly coupled Gerrit is with Git itself, so much so that you submit changes by **pushing** as if the Gerrit server were "just another Git repo."