As pidfd isn't available in older versions of Linux that Rust still
supports, this is necessary for running on older Linux. In addition,
signals tests are still kept in CI.
Signed-off-by: John Nunley <dev@notgull.net>
This commit adds a new backend for the process reaper. Rather than
waiting on a signal, it instead registers the process's pidfd into
async-io and waits on that instead.
I've coded this backend to also allow for other systems to be registered
here as well.
Signed-off-by: John Nunley <dev@notgull.net>
I know I said that I wouldn't add any more features, but I
think this is important enough.
Right now, a thread called "async-process" is responsible for listening
for SIGCHLD and reaping zombie processes. This listens for the SIGCHLD
signal in Unix and uses a channel connected to the waitable handle on
Windows. While this works, we can do better. Through async-signal, the
signal was already asynchronous on Unix; we were already just using
async_io::block_on to wait on the signal. After swapping out the channel
used on Windows with async-channel, the process reaping function "reap"
can be reimplemented as a fully asynchronous future.
From here we must make sure this future is being polled at all times. To
facilitate this, a function named "driver()" is added to the public API.
This future acquires a lock on the reaper structure and calls the
"reap()" future indefinitely. Multiple drivers can be created at once;
they will just wait forever on this lock. This future is intended to be
spawned onto an executor and left to run forever, making sure all child
processes are signalled whenever necessary. If no tasks are running the
driver future, the "async-process" thread is spawned and runs the
"reap()" future itself.
I've added the following controls to make sure that this system is
robust:
- If a "driver" task is dropped, another "driver" task will acquire the
lock and keep the reaper active.
- Before being dropped, the task checks to see if it is the last driver.
If it is, it will spawn the "async-process" thread to be the driver.
- When a Child is being created, it checks if there are any active
drivers. If there are none, it spawns the "async-process" thread
itself.
- One concern is that the driver future wil try to spawn the
"async-process" thread as the application exits and the task is being
dropped, which will be unnecessary and lead to slower shutdowns. To
prevent this, the future checks to see if there are any extant `Child`
instances (a new refcount is added to Reaper to facilitate this). If
there are none, and if there are no zombie processes, it does not
spawn the additional thread.
- Someone can still `mem::forget()` the driver thread. This does not
lead to undefined behavior and just leads to processes being left
dangling. At this point they're asking for wacky behavior.
This strategy might also be viable for `async-io`, if we want to try to
avoid needing to spawn the additional thread there as well.
Closes#7
cc smol-rs/async-io#40
Signed-off-by: John Nunley <dev@notgull.net>
The purpose for removing this function is twofold:
- It is the only unsafe code in this crate that can't be realistically
replaced with safe code.
- It is a footgun anyways, and can be done anyways with Into::into() if
users really want it.
This is a breaking change.
Signed-off-by: John Nunley <dev@notgull.net>
```
error: the borrowed expression implements the required traits
--> src/lib.rs:212:57
|
212 | signal_hook::iterator::Signals::new(&[signal_hook::consts::SIGCHLD])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[signal_hook::consts::SIGCHLD]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
error: the borrowed expression implements the required traits
--> tests/std.rs:14:38
|
14 | Command::new("cmd").args(&["/C", "exit 0"]).spawn()
| ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 0"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
error: the borrowed expression implements the required traits
--> tests/std.rs:35:38
|
35 | Command::new("cmd").args(&["/C", "exit 1"]).spawn()
| ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:87:22
|
87 | cmd.args(&["/C", "echo foobar"]).stdout(Stdio::piped());
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "echo foobar"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:145:23
|
145 | .args(&["/C", "exit 1"])
| ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:156:23
|
156 | .args(&["/C", "exit 0"])
| ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 0"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:189:23
|
189 | .args(&["/C", "echo hello"])
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "echo hello"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:213:23
|
213 | .args(&["/C", "mkdir ."])
| ^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "mkdir ."]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:231:38
|
231 | Command::new("cmd").args(&["/C", "exit 1"]).spawn().unwrap()
| ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:243:38
|
243 | Command::new("cmd").args(&["/C", "exit 1"]).spawn().unwrap()
| ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: the borrowed expression implements the required traits
--> tests/std.rs:257:23
|
257 | .args(&["/C", "echo hello"])
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "echo hello"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
```
In normal mode `Debug` now prints just the command-line (similarly to
`std::process::Command`). This is useful for logging commands and
formatting error messages that includes command-line.
In "alternate" mode full internals of this structure are still printed.
The dependency on version v0.1.16 of signal-hook makes this library
impossible to use in a project alongside signal-hook version v0.3.0.
This is caused by an arguably incorrect dependency from signal-hook
v0.1.16 on `~1.2` of signal-hook-registry (I think it should just depend
on `^1.2` instead), however it seemed more beneficial overall to upgrade
this crate's dependency instead.
cowlicks
kennytm
John Nunley
Taiki Endo
John Nunley
Alexander Berger
Jesse Luehrs
Paul Colomiets
Félix Saparelli
BinCheng
Jayce Fayne
Alexandru Macovei
Wesley Merkel
Stjepan Glavina